Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide deprecation path for AIIDA_CONFIG_FOLDER #6656

Closed
khsrali opened this issue Dec 9, 2024 · 2 comments
Closed

Provide deprecation path for AIIDA_CONFIG_FOLDER #6656

khsrali opened this issue Dec 9, 2024 · 2 comments

Comments

@khsrali
Copy link
Contributor

khsrali commented Dec 9, 2024

Regarding merged PR #6610, I believe we still need to support AIIDA_CONFIG_FOLDER within a deprecation path.

aiida-workgraph and aiida-pythonjob now fail, because they used to use the public method AIIDA_CONFIG_FOLDER.

@unkcpz
Copy link
Member

unkcpz commented Dec 10, 2024

The AIIDA_CONFIG_FOLDER was never recommended as public APIs. IMO, the deprecation warnings should only put for public APIs.
Instead of provide deprecation path, if it is necessary to expose it as public API, we should do that first.

@unkcpz unkcpz closed this as completed Dec 10, 2024
@unkcpz
Copy link
Member

unkcpz commented Dec 10, 2024

There are exposed API for getting the config path

from aiida.manage import get_config
config = get _config()
config_path = config.dirpath

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants