Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AIIDA_CONFIG_FOLDER -> AiiDAConfigDir #387

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Refactor AIIDA_CONFIG_FOLDER -> AiiDAConfigDir #387

merged 3 commits into from
Dec 10, 2024

Conversation

khsrali
Copy link
Contributor

@khsrali khsrali commented Dec 9, 2024

After aiidateam/aiida-core#6610 by @unkcpz AIIDA_CONFIG_FOLDER has changed to AiiDAConfigDir,
This PR refactors that accordingly.
(a similar PR opened on aiidateam/aiida-pythonjob#9)

@superstar54
Copy link
Member

Hi @khsrali , thanks for taking care of this issue! Could you use the API suggested by @unkcpz?

@superstar54 superstar54 self-requested a review December 10, 2024 15:00
superstar54
superstar54 approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@superstar54 superstar54 merged commit df7374b into aiidateam:main Dec 10, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unkcpz unkcpz unkcpz left review comments

@superstar54 superstar54 superstar54 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@khsrali @superstar54 @unkcpz