DOC: update the image name for docker image #6143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unkcpz
force-pushed
the
doc/xx/installation-docker
branch
from
005a415 to
5a57c00
Compare
|
It is a chick-egg problem if this PR merged first (then the |
unkcpz
commented
Oct 9, 2023
| @@ -19,29 +19,19 @@ This image contains a fully pre-configured AiiDA environment which makes it part | |||
|
|
|||
| To install Docker, please refer to the `official documentation <https://docs.docker.com/get-docker/>`__. | |||
|
|
|||
| .. note:: | |||
|
|
|||
| If you are using Linux, you need to have root privileges to do `post-installation steps for the Docker Engine <https://docs.docker.com/engine/install/linux-postinstall/>`__. | |||
There was a problem hiding this comment.
This is not required anymore since for the linux the official docker doc also recommend to use docker desktop.
There was a problem hiding this comment.
I think it is fine to have the latest docs to point to a release that does not exist yet. We will be releasing soon.
sphuber
reviewed
Oct 10, 2023
sphuber
pushed a commit
that referenced
this pull request
Nov 14, 2023
It was still pointing to the old name instead of the new `aiida-core-with-services`. Cherry-pick: 5ca609b
sphuber
pushed a commit
that referenced
this pull request
Nov 15, 2023
It was still pointing to the old name instead of the new `aiida-core-with-services`. Cherry-pick: 5ca609b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.