Docker: Start/Stop daemon only when profile exist #6257
Conversation
unkcpz
force-pushed
the
fix/6252/start-daemon-when-profile-set
branch
6 times, most recently
from
f8ea609 to
355da79
Compare
unkcpz
changed the title
unkcpz
force-pushed
the
fix/6252/start-daemon-when-profile-set
branch
3 times, most recently
from
7baf82a to
1efa938
Compare
| # Supress rabbitmq version warning | ||
| # If it is built using RMQ version > 3.8.15 (as we did for the `aiida-core-with-services` image) which has the issue as described in | ||
| # https://github.com/aiidateam/aiida-core/wiki/RabbitMQ-version-to-use | ||
| # We explicitly set consumer_timeout to disabled in /etc/rabbitmq/rabbitmq.conf | ||
| verdi config set warnings.rabbitmq_version False |
There was a problem hiding this comment.
Won't this be run every time the container is started? Guess this would have to be setup just once, shouldn't it? When the profile is set up the first time, just like you set verdi config set warnings.development_version False
There was a problem hiding this comment.
Yes, I think you are right. It is not proper to put it here (at least it is not proper to put it in two places) which will execute every time the daemon start.
But if the config is put in the aiida-prepare.sh as it did before. Then if the SETUP_DEFAULT_AIIDA_PROFILE is set to false, the config will also be skipped and users will always see two warnings if the profile is not set by default.
I think more properly is that the verdi config can run independent of profile, but I think it is not the case at the moment correct? I run verdi config set warnings.rabbitmq_version False without profile, I got:
Traceback (most recent call last):
File "/opt/conda/lib/python3.10/site-packages/aiida/common/extendeddicts.py", line 49, in __getattr__
return self[attr]
KeyError: 'profile'
There was a problem hiding this comment.
Can you try with the --global flag? By default verdi config set will apply it to the current default profile, which if that doesn't exist of course fails. But maybe setting globally will work.
There was a problem hiding this comment.
With the verdi config set --global bug solved, I guess this can now move forward, right?
There was a problem hiding this comment.
The --global is not needed, if the profile not exist the config set will fallback to set as global. I update the PR, ready for the review.
unkcpz
force-pushed
the
fix/6252/start-daemon-when-profile-set
branch
from
1efa938 to
f572fab
Compare
.docker/aiida-core-base/s6-assets/s6-rc.d/aiida-daemon-start/down
Outdated
Show resolved
Hide resolved
unkcpz
force-pushed
the
fix/6252/start-daemon-when-profile-set
branch
from
2ecb24b to
c73bcfa
Compare
Daemon stop as well [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci f-m iron docker CI format
Co-authored-by: Sebastiaan Huber <[email protected]>
unkcpz
force-pushed
the
fix/6252/start-daemon-when-profile-set
branch
from
c73bcfa to
da08a5b
Compare
The container will try to start the daemon. But in #6252, we allowed user to skip the default profile setup, this will fail the daemon start and pop an traceback message to container shell.
In this commit, I run
verdi profile showto check if the profile exist, and start daemon only if it can start.