Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ssh channel timeout configurable for exec_command_wait_bytes #6452

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Jun 5, 2024

fixes #6377

Just make it configurable, not changing behavior. In aiida-hyperqueue, we call the exec_command_wait_bytes directly. It seems the only use case at the moment that need this.

The changes is test from branch v2.5.1 the production environment I used, so it would be nice if it can backported to support/2.5.x

@unkcpz unkcpz requested a review from sphuber June 5, 2024 12:44
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.86%. Comparing base (c4afdd0) to head (5ae1dbc).
Report is 198 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6452      +/-   ##
==========================================
+ Coverage   77.73%   77.86%   +0.14%     
==========================================
  Files         548      562      +14     
  Lines       40221    41794    +1573     
==========================================
+ Hits        31260    32539    +1279     
- Misses       8961     9255     +294     
Flag Coverage Δ
presto 73.19% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@sphuber sphuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @unkcpz . Since v2.6 is right around the corner, would you really need a patch release?

@sphuber sphuber merged commit 7cb0068 into aiidateam:main Jun 6, 2024
9 of 10 checks passed
@unkcpz unkcpz deleted the fix/6377/make-ssh-channel-timeout-configurable branch June 6, 2024 09:16
@unkcpz
Copy link
Member Author

unkcpz commented Jun 6, 2024

Since v2.6 is right around the corner, would you really need a patch release?

I'd say so, I want to stick to 2.5.x as production environment (which is almost flawless for my use case, if I ignore the caching problem) to finalize the SSSP running, otherwise there may be more issues coming up for the new minor version.

sphuber pushed a commit that referenced this pull request Jun 6, 2024
mikibonacci pushed a commit to mikibonacci/aiida-core that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the ssh channel timeout configurable?
2 participants