CLI: Add RabbitMQ options to verdi profile setup

[sphuber]

The verdi profile setup command was added to replace the deprecated command verdi setup. The new command dynamically generates a subcommand for each installed storage plugin.

However, the new command did not allow to configure the connection parameters for the RabbitMQ broker, unlike verdi setup. These common options are now added to the subcommands.

In addition, a new option is added --use-rabbitmq/--no-use-rabbitmq. This flag is on by default, to keep the old behavior of verdi setup. When toggled to --no-use-rabbitmq, the RabbitMQ configuration options are no longer required and are also not prompted for. The profile is then configured without a broker.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.74%. Comparing base (ef60b66) to head (ad7bef6).
Report is 112 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6453      +/-   ##
==========================================
+ Coverage   77.51%   77.74%   +0.24%     
==========================================
  Files         560      561       +1     
  Lines       41444    41752     +308     
==========================================
+ Hits        32120    32456     +336     
+ Misses       9324     9296      -28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[GeigerJ2]

Just took it for a spin and looks all good to me. Only noted a small typo.

[sphuber]

Thanks for the review @GeigerJ2

[mbercx]

Hi guys, again sorry for being a late party-pooper. My main question is if we want to add these RabbitMQ-specific options to all of the setup commands. Now that we have a command for reconfiguring rabbitmq, can't we just use the defaults and then point the user to this command in case they want to use others?

I think we already foresee that we want to try and add a different broker than RabbitMQ. Presumably the options for this broker might be different. Are we going to add all the options for that broker here as well? Should we then also rename the rabbitmq options? (which are now all --broker-X).

I would stick with just adding --use-rabbitmq / --no-use-rabbitmq, use the defaults for the configuration, add a check to see if it worked and point them to the configure-rabbitmq command if it failed.