Docker image tweaks #6466
Merged
Docker image tweaks #6466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhollas
commented
Jun 6, 2024
| @@ -22,8 +22,7 @@ RUN mamba install --yes \ | |||
| # Install erlang. | |||
| RUN apt-get update --yes && \ | |||
| apt-get install --yes --no-install-recommends \ | |||
| erlang \ | |||
| xz-utils && \ | |||
There was a problem hiding this comment.
Already installed in aiida-core-base
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6466 +/- ##
==========================================
+ Coverage 77.51% 77.83% +0.33%
==========================================
Files 560 561 +1
Lines 41444 41767 +323
==========================================
+ Hits 32120 32505 +385
+ Misses 9324 9262 -62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mikibonacci
pushed a commit
to mikibonacci/aiida-core
that referenced
this pull request
Sep 3, 2024
* Remove pin of mamba version * Set `PIP_USER` as default * Remove double install of `xz-utils`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tweaks to Docker images
--userflag to pip default. We want users to install to~/.localsince the home directory is preserved on a volume when the container stops. We do the same in aiidalab-docker-stack