Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QueryBuilder: Fix type bugs for PostgreSQL backend #6658

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

rabbull
Copy link
Contributor

@rabbull rabbull commented Dec 10, 2024

In #6619 some bugs in QueryBuilder for PostgreSQL backend are found. Because the fixes are not directly related to the topic of the PR, a new PR is created to address these bugs.

Related tests will be delievered in #6619.

Copy link
Contributor

@GeigerJ2 GeigerJ2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 77.92%. Comparing base (37e5431) to head (854545e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rc/aiida/storage/psql_dos/orm/querybuilder/main.py 11.12% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6658      +/-   ##
==========================================
- Coverage   77.93%   77.92%   -0.01%     
==========================================
  Files         563      563              
  Lines       41662    41668       +6     
==========================================
  Hits        32464    32464              
- Misses       9198     9204       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GeigerJ2 GeigerJ2 merged commit 53be737 into aiidateam:main Dec 10, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants