Adapt message arguments passing to process controller #6668
Conversation
unkcpz
force-pushed
the
conform-with-new-plumpy-message-options
branch
from
0f5beb4 to
05b51e4
Compare
unkcpz
force-pushed
the
conform-with-new-plumpy-message-options
branch
from
a55e16c to
8751167
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6668 +/- ##
==========================================
+ Coverage 77.99% 77.99% +0.01%
==========================================
Files 563 563
Lines 41761 41762 +1
==========================================
+ Hits 32567 32570 +3
+ Misses 9194 9192 -2 ☔ View full report in Codecov by Sentry. |
| @@ -199,7 +201,8 @@ def kill_processes( | |||
| return | |||
|
|
|||
| controller = get_manager().get_process_controller() | |||
| _perform_actions(processes, controller.kill_process, 'kill', 'killing', timeout, wait, msg=message) | |||
| action = functools.partial(controller.kill_process, msg_text=msg_text) | |||
| _perform_actions(processes, action, 'kill', 'killing', timeout, wait) | |||
There was a problem hiding this comment.
Thanks @unkcpz
in _perform_actions we have:
future = action(process.pk, **kwargs)Therefore I would suggest, either put everything inside functools.partial so it would be serve as we suggested and discussed (one action that would be triggered), or probably take the msg_text out.
Right now, it's kinda hard to understand why because the rest of arguments are passed via **kwargs .
There was a problem hiding this comment.
Yep, makes sense. I I removed the kwargs and add the typing for action argument as well.
| @@ -231,7 +234,7 @@ def _perform_actions( | |||
| continue | |||
|
|
|||
| try: | |||
| future = action(process.pk, **kwargs) | |||
| future = action(process.pk) | |||
There was a problem hiding this comment.
are the docs still up to date if you remove usage of kwargs?
There was a problem hiding this comment.
Good point, I just remove the use of kwargs and the docstring see 72b77cb
unkcpz
force-pushed
the
conform-with-new-plumpy-message-options
branch
from
87d7c51 to
3fd268a
Compare
|
@khsrali I rebase with the main branch of plumpy, all CI code tests are passed. We can make a release for plumpy. |
|
Hi @khsrali, I update plumpy version, should all good now. Can you have another look? |
Changes required after aiidateam/plumpy#301 and aiidateam/plumpy#291