Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use uv lockfile in readthedocs build #6685

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

danielhollas
Copy link
Collaborator

@danielhollas danielhollas commented Jan 8, 2025

Now that we have a bit of good experience with uv lockfile, it would be nice to use it in more places to make various CI jobs more stable. Here I am using it for the RTD docs build. We've already been using uv there so that change is relatively straightforward.

Coincidentaly, ReadTheDocs made some updates to make the configuration with uv nicer, just a couple of days ago see readthedocs/readthedocs.org#11289 (comment) for details.

This also updates the uv version in RTD config.

@danielhollas danielhollas changed the title Simplify uv configuration in .reatthedocs.yml Use uv lockfile in readthedocs build Jan 9, 2025
@danielhollas danielhollas marked this pull request as ready for review January 9, 2025 16:50
@danielhollas
Copy link
Collaborator Author

danielhollas commented Jan 9, 2025

Huh, 20 tests failed on my, such as

FAILED tests/orm/nodes/data/test_remote.py::test_get_size_on_disk_params[setup0-results0-local] - AssertionError: assert ('12.00 B', 'du') == ('4.01 KB', 'du')
  At index 0 diff: '12.00 B' != '4.01 KB'
  Full diff:
  - ('4.01 KB', 'du')
  ?   ^  ^^^
  + ('12.00 B', 'du')
  ?   ^^  ^^
FAILED tests/orm/nodes/data/test_remote.py::test_get_size_on_disk_params[setup0-results0-ssh] - AssertionError: assert ('12.00 B', 'du') == ('4.01 KB', 'du')
  At index 0 diff: '12.00 B' != '4.01 KB'
  Full diff:
  - ('4.01 KB', 'du')
  ?   ^  ^^^
  + ('12.00 B', 'du')
  ?   ^^  ^^

https://github.com/danielhollas/aiida-core/actions/runs/12694592672/job/35384697895

Is this a know failure? Weirdly, the tests pass on this PR.

@danielhollas danielhollas force-pushed the rtd-uv-update branch 2 times, most recently from 1786bf4 to 677dc31 Compare January 9, 2025 17:14
@danielhollas
Copy link
Collaborator Author

The failing test is due to the timeout issue.

@unkcpz
Copy link
Member

unkcpz commented Jan 10, 2025

Huh, 20 tests failed on my, such as

FAILED tests/orm/nodes/data/test_remote.py::test_get_size_on_disk_params[setup0-results0-local] - AssertionError: assert ('12.00 B', 'du') == ('4.01 KB', 'du')
  At index 0 diff: '12.00 B' != '4.01 KB'
  Full diff:
  - ('4.01 KB', 'du')
  ?   ^  ^^^
  + ('12.00 B', 'du')
  ?   ^^  ^^
FAILED tests/orm/nodes/data/test_remote.py::test_get_size_on_disk_params[setup0-results0-ssh] - AssertionError: assert ('12.00 B', 'du') == ('4.01 KB', 'du')
  At index 0 diff: '12.00 B' != '4.01 KB'
  Full diff:
  - ('4.01 KB', 'du')
  ?   ^  ^^^
  + ('12.00 B', 'du')
  ?   ^^  ^^

https://github.com/danielhollas/aiida-core/actions/runs/12694592672/job/35384697895

Is this a know failure? Weirdly, the tests pass on this PR.

It seems not relate to timeout, and it only failed on your forked CI?

BTW, the changes looks good, thanks for the work.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.99%. Comparing base (3f5e2c1) to head (39c4ad3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6685   +/-   ##
=======================================
  Coverage   77.99%   77.99%           
=======================================
  Files         563      563           
  Lines       41761    41761           
=======================================
  Hits        32567    32567           
  Misses       9194     9194           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielhollas
Copy link
Collaborator Author

danielhollas commented Jan 10, 2025

and it only failed on your forked CI?

Looks like this was because the jobs on my fork used the new ubuntu-24.04 runners, which somehow make the tests fail. I've reproduced it in #6696. I'll open an separate issue. In any case, not related to this PR.

Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for further checking on thttps://github.com//pull/6696, this one looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants