Timeout for single pytest to 240s

[unkcpz]

In #6674 I set timeout to 60s, but 60s for some tests are too short.
There is an issue open to discuss whether we need to move those to nightly, see #6526 for more discussion.

Really sorry for the #6674, didn't expect 60s still too short.

[unkcpz]

@danielhollas I increase the overrall timeout to 120s not just for the tests/tools/archive/orm/test_links.py::test_high_level_workflow_links, because @khsrali reported he also saw other two tests can timeout. I hope 120s is fine, or I'll just revert the change?

[danielhollas]

Since we're currently still seeing issues/failures due to parallel test execution (pytest-xdist), I would slightly prefer to remove the timeout for now so we don't fight two sources of flakiness at once. But I don't feel too strongly, feel free to merge as is.

[khsrali]

We could also add a timeout only for tests that 'requires_rmq', if that was the reason timeout were added in the first place.

But for now, I agree with @danielhollas that we could just remove it. Since GitHub workers are not reliably running with the same pace always.

[unkcpz]

It was trying to solve things like #6659 where the tests timeout after 90m because some hang up. I'd merge as it is, because I think timeout will help PR like #6659.

For the xdist, I think this also helps, no? If something wrong with daemon because of some test racing, it will hang. With timeout, we can quick stop and go to check.

EDIT: @khsrali suggest offline if I want to go with this, run all test suits three times to see nothing failed.

[danielhollas]

It was trying to solve things like #6659 where the tests timeout after 90m because some hang up. I'd merge as it is, because I think timeout will help PR like #6659.

If the main motivation for the timeout is to fail the test suite earlier when a test hangs, then I would suggest to bump the timeout even more, e..g. to 180s or 240s. Since we're running tests in parallel, having the timeout larger should not prolong the overall time as much. Once the tests have been stable for a couple months, and once we perhaps move the slowest tests to nightly, we can revisit the value.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.94%. Comparing base (1093026) to head (031be8a).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6692   +/-   ##
=======================================
  Coverage   77.94%   77.94%           
=======================================
  Files         563      563           
  Lines       41761    41761           
=======================================
  Hits        32545    32545           
  Misses       9216     9216           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.