-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manifest bump ipython to new version will fail the test #6697
Conversation
The problem can not manifest by updating the ipython, the failed test is:
|
I track to ipython/ipython#13268, and find it relates to the VIRTUAL_ENV which @danielhollas you may adapted a bit in ci? Any idea? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6697 +/- ##
=======================================
Coverage 77.99% 77.99%
=======================================
Files 563 563
Lines 41761 41761
=======================================
Hits 32567 32567
Misses 9194 9194 ☔ View full report in Codecov by Sentry. |
We already have a workaround for this that's only applied for python 3.9, and related to I suspect you're triggering this even for Python. 3.12 because you have an old uv version locally. I will need to think about if / how to enforce minimum uv version. I think this PR is not needed, we're just waiting for a new setup-uv release and then we'll be able to drop the existing workaround. |
1835258
to
7e741d4
Compare
As you mentioned, it is the problem with my local uv version. Thanks for help. |
uv.lock
is updated by runninguv lock --upgrade-package ipython
. The problem was found and redirected from #6694