pre-commit: autorun uv lock if --check fails

[khsrali]

why not?

[unkcpz]

Is this to fix the failed CI, why they are failed now? Is this one covered by #6699? @danielhollas

[khsrali]

Is this to fix the failed CI, why they are failed now? Is this one covered by #6699? @danielhollas

CI fails for different reasons, probably because #6712
I wasn't aware of #6699, will have a look on that 👀

[danielhollas]

Yes, #6699 should cover this.

For the failing CI, please update your uv version and then try to update the lock.
There were changes in the version from yesterday for handling of dynamic version (which we do have in our pyproject.toml)

[unkcpz]

The latest uv version now is 0.5.20, I update and rerun uv lock --upgrade. The CI tests are fine now but the readthedocs build failed on uv sync --extra docs --extra tests --extra rest --extra atomic_tools with:

error: Failed to parse `uv.lock`
  Caused by: TOML parse error at line 25, column 1
   |
25 | [[package]]
   | ^^^^^^^^^^^
missing field `version`

I assume the readthedocs build config should also sync the uv version.

[danielhollas]

You'll need to update the uv version in the RTD config. We'll need to figure out how to manage the uv version better, since the lockfile is clearly still in flux even in patch versions.

…

On Thu, Jan 16, 2025, 10:55 Jusong Yu ***@***.***> wrote: The latest uv version now is 0.5.20, I update and rerun uv lock --upgrade. The CI tests are fine now but the readthedocs build failed on uv sync --extra docs --extra tests --extra rest --extra atomic_tools with: error: Failed to parse `uv.lock` Caused by: TOML parse error at line 25, column 1 | 25 | [[package]] | ^^^^^^^^^^^ missing field `version` — Reply to this email directly, view it on GitHub <#6711 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACIY64OK6RHAWVGXMHA7CLT2K6FZTAVCNFSM6AAAAABVJD6HGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOJVGIYDIMRRGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[unkcpz]

Thanks for quick reply @danielhollas
Would you mind I bump uv version in RTD in my other PR and merge? Or you prefer to wait until it covered by an independent solution?

[danielhollas]

Would you mind I bump uv version in RTD in my other PR and merge? Or you prefer to wait until it covered by an independent solution?

Go for it.

[danielhollas]

I'd prefer if we could fix this in #6699 since that one can also enforce a specific uv version. Maybe let's leave this as a draft as a backup plan if #6699 cannot be merged in a reasonable timeframe.

[danielhollas]

I am not sure it this works correctly, because we need to fail the pre-commit check if the lockfile is updated, but based on my limited testing uv lock returns 0 regardless if the lockfile was updated or not.

[khsrali]

I guess with --check return zero only if lockfile is already updated.
I ran a few manual tests, for me it works.

[khsrali]

I'd prefer if we could fix this in #6699 since that one can also enforce a specific uv version. Maybe let's leave this as a draft as a backup plan if #6699 cannot be merged in a reasonable timeframe.

yes, absolutely! I wasn't aware of your PR before opening this :-)

[khsrali]

@danielhollas now that the minimum version is set,
maybe we can take this temporary solution to have a cautious pre-commit
I'm not aware how long it takes for uv to merge their thing

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.00%. Comparing base (c88fc05) to head (cc5221e).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6711   +/-   ##
=======================================
  Coverage   78.00%   78.00%           
=======================================
  Files         563      563           
  Lines       41766    41766           
=======================================
  Hits        32574    32574           
  Misses       9192     9192           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[danielhollas]

Well, the bug that I reported yesterday that was blocking us is already fixed. 😄
astral-sh/uv#10689

So let's wait for next release, which will most likely happen sometimes next week, they release very often.

[khsrali]

solution #6699 is preferred.