-
Notifications
You must be signed in to change notification settings - Fork 232
Drop api-auto-docs for now #7056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Houston, We Have a Problem! |
|
Classic example of "should be quick" :/ good luck with this, guys, you will need it :D |
|
@khsrali @edan-bainglass have you seen this page? https://docs.readthedocs.com/platform/stable/config-file/v2.html#search It looks like the ranking needs to be configured in the Line 34 in cf690e4
Can you try changing See also discussion in the original PR at #4217 |
Sorry, I was wrong. But I think it's still worth investigating if the existing configuration can be fixed I think. |
|
@khsrali you inspired me: aiidateam/aiida-quantumespresso#1186 (along with the AutoAPI docs failing again on a totally random PR: aiidateam/aiida-quantumespresso#1185) Re the references: I've "fixed" the issue by simply adding a line to the nitpick_ignore_regex = [
...
(r'py:.*', r'aiida_quantumespresso.*'),
] |
396a966 to
9d46775
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7056 +/- ##
==========================================
- Coverage 79.29% 79.28% -0.00%
==========================================
Files 566 566
Lines 43847 43847
==========================================
- Hits 34763 34760 -3
- Misses 9084 9087 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9d46775 to
12a9801
Compare
The results already has improved quite a lot without autodoc. |
|
@khsrali have you looked into @danielhollas's suggestion? #7056 (comment) |
|
|
Okay. Sorry, I don't have time to check this. @danielhollas seems to think this is the right path. Maybe have a look at the referenced PR for inspiration. If all else fails, you can proceed with this one. I'll approve now. |
edan-bainglass
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The `aiida-core` AutoAPI docs have been (temporarily) disabled in: aiidateam/aiida-core#7056 Since we still have several intersphinx references to the `aiida-core` AutoAPI docs, our build started failing on RTD. Here we ignore any issues with missing `aiida-core` references by adding a broad regex to the `nitpick_ignore_regex`. We could also remove the references, but we haven't settled yet on whether to reintroduce the AutoAPI docs in the future (also for this package).
The `aiida-core` AutoAPI docs have been (temporarily) disabled in: aiidateam/aiida-core#7056 Since we still have several intersphinx references to the `aiida-core` AutoAPI docs, our build started failing on RTD. Here we ignore any issues with missing `aiida-core` references by adding a broad regex to the `nitpick_ignore_regex`. We could also remove the references, but we haven't settled yet on whether to reintroduce the AutoAPI docs in the future (also for this package).
The `aiida-core` AutoAPI docs have been (temporarily) disabled in: aiidateam/aiida-core#7056 Since we still have several intersphinx references to the `aiida-core` AutoAPI docs, our build started failing on RTD. Here we ignore any issues with missing `aiida-core` references by adding a broad regex to the `nitpick_ignore_regex`. We could also remove the references, but we haven't settled yet on whether to reintroduce the AutoAPI docs in the future (also for this package).

When using the search bar, all un-related api results is shown and makes it incredibly difficult to fetch the result of actual documentation.
I first, aimed to remove api-doc from the search results. But sphinx doesn't allow it. I struggled two hours with no success.
@edan-bainglass also looked up these references:
https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-html_search_scorer
https://docs.readthedocs.com/dev/latest/search-integration.html
Unfortunately it seems not doable. Or requires two days of work to make it.
We suggest to drop api-auto-docs for now, as an urgent solution. If one finds a solution in future they can safely revert this PR/commit.