Autogenerate aiida.brokers __init__ files, make RabbitmqBroker public #7127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7127 +/- ##
==========================================
+ Coverage 79.59% 79.60% +0.02%
==========================================
Files 566 566
Lines 43543 43541 -2
==========================================
+ Hits 34654 34658 +4
+ Misses 8889 8883 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danielhollas
force-pushed
the
autogenerate-brokers-inits
branch
from
7d3f9cc to
5246928
Compare
Contributor
|
@danielhollas I think @agoscinski is a better reviewer for this PR, since he's touching the topic currently. |
Collaborator
Author
|
@khsrali thanks, sounds good! |
Collaborator
Author
|
@agoscinski can you take a quick look? This is a small and (hopefully) non-controversial change that I split from #7091 for easier review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #7091.
In this PR we expose RabbitmqBroker as a public interface, which I think makes sense.
On the other hand, other variables probably should not be public so I removed them from
__all__definitions, otherwise they would be added automatically once we land #7091.@GeigerJ2 not sure who would be best to review this.