Strict typing for aiida.schedulers module #7136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielhollas
requested review from
khsrali
and removed request for
agoscinski and
unkcpz
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7136 +/- ##
==========================================
+ Coverage 79.61% 79.62% +0.02%
==========================================
Files 566 566
Lines 43572 43576 +4
==========================================
+ Hits 34684 34694 +10
+ Misses 8888 8882 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danielhollas
force-pushed
the
typing-schedulers-strict
branch
from
d93a23e to
129ed13
Compare
khsrali
reviewed
Dec 8, 2025
Some scheduler plugins are still esxcluded from type-checking, will deal with that separately.
danielhollas
force-pushed
the
typing-schedulers-strict
branch
from
129ed13 to
7917304
Compare
khsrali
approved these changes
Dec 10, 2025
Contributor
khsrali
left a comment
khsrali
left a comment
There was a problem hiding this comment.
@danielhollas , I haven't checked if there are any new changes after your force pushed. If that's the case let me know what have you changed, otherwise all good!
Collaborator
Author
Just a rebase on main. Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some scheduler plugins are still excluded from type-checking, will deal with that separately to keep this PR manageable.