Skip to content

Use proper RST code directives in docstring of QB in method #7146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GeigerJ2 merged 1 commit into from
Dec 10, 2025
Merged

Use proper RST code directives in docstring of QB in method #7146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions src/aiida/storage/psql_dos/orm/querybuilder/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -778,24 +778,25 @@ def _create_smarter_in_clause(self, column, values_list):
The 500k batch threshold is chosen to balance several factors:

- **Parameter limits**: Each batch uses 1 parameter. With SQLite's minimum limit of 999
parameters, this allows up to ~500M items (999 x 500k). PostgreSQL's limit of ~65k
parameters allows up to ~33B items (65,535 x 500k).
parameters, this allows up to ~500M items (999 x 500k). PostgreSQL's limit of ~65k
parameters allows up to ~33B items (65,535 x 500k).
- **Memory constraints**: In practice, Python memory becomes the bottleneck before
database limits. A list of 500M items would require 4-20GB RAM before even reaching
the database.
database limits. A list of 500M items would require 4-20GB RAM before even reaching
the database.
- **Database performance**: Modern databases handle 500k-item arrays/JSON easily on
typical workstations and servers.
typical workstations and servers.

For example:
Small list (50k items):
WHERE column IN (SELECT unnest(:array)) -- 1 parameter
For example, small list (50k items)::

Large list (1.5M items):
WHERE (
column IN (SELECT unnest(:array_1)) -- First 500k
OR column IN (SELECT unnest(:array_2)) -- Second 500k
OR column IN (SELECT unnest(:array_3)) -- Remaining 500k
)
WHERE column IN (SELECT unnest(:array)) -- 1 parameter

Large list (1.5M items)::

WHERE (
column IN (SELECT unnest(:array_1)) -- First 500k
OR column IN (SELECT unnest(:array_2)) -- Second 500k
OR column IN (SELECT unnest(:array_3)) -- Remaining 500k
)
"""
import json

Expand Down