Update tested RabbitMQ versions in nightly test#7373
Open
danielhollas wants to merge 4 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7373 +/- ##
==========================================
- Coverage 80.38% 80.37% -0.00%
==========================================
Files 578 578
Lines 46126 46126
==========================================
- Hits 37073 37071 -2
- Misses 9053 9055 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danielhollas
force-pushed
the
test-rmq-latest
branch
from
b9c43c2 to
c11e22a
Compare
danielhollas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should be testing the latest RabbitMQ version in nightly testsWe cannot test RMQ latest because version 4.3 broke AiiDA, see #7375
So we test with 4.2 as the latest supported. I've set the minimum tested version to 3.10 since that's the version we currently use in AiiDAlab.
I've removed testing versions in between since we've never seen issues specific to these specific versions so it seems like an overkill to test all of them.