Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Release v4.8.0 #1063

Merged
merged 1 commit into from
Jan 22, 2025
Merged

🚀 Release v4.8.0 #1063

merged 1 commit into from
Jan 22, 2025

Conversation

mbercx
Copy link
Member

@mbercx mbercx commented Jan 22, 2025

No description provided.

@mbercx mbercx requested a review from t-reents January 22, 2025 08:48
@mbercx
Copy link
Member Author

mbercx commented Jan 22, 2025

Hmm, let me see why it's still trying those tests (3.8 which aren't running...

@mbercx
Copy link
Member Author

mbercx commented Jan 22, 2025

Was since the tests (3.8) were still one of the tests that had to pass according to the branch protections.

@AndresOrtegaGuerrero
Copy link
Collaborator

@mbercx , could you mayeb have a look on , #1052 , before doing the release, so we can fix the issues we are having with the pdos in qe app

@mbercx
Copy link
Member Author

mbercx commented Jan 22, 2025

@AndresOrtegaGuerrero I will most likely not have time to do so this week, and your comment here regarding the issues with parsing of the projwfc.x means getting that fixed properly might still take some time, especially if we want to try to merge #749, which technically should fix that problem but is quite a beast.

Doing a release is quite quick, really. So I'd rather get this out now instead of blocking it for #1052.

@AndresOrtegaGuerrero
Copy link
Collaborator

@AndresOrtegaGuerrero I will most likely not have time to do so this week, and your comment here regarding the issues with parsing of the projwfc.x means getting that fixed properly might still take some time, especially if we want to try to merge #749, which technically should fix that problem but is quite a beast.

Doing a release is quite quick, really. So I'd rather get this out now instead of blocking it for #1052.

Sure

@mbercx mbercx merged commit c84ef21 into main Jan 22, 2025
13 checks passed
@mbercx mbercx deleted the release/4.8.0 branch January 22, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants