Add README translation #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicl-nno
reviewed
Sep 29, 2025
nicl-nno
reviewed
Sep 29, 2025
nicl-nno
reviewed
Sep 29, 2025
nicl-nno
reviewed
Sep 29, 2025
Comment on lines
24
to
42
| async def translate_readme_request_async( | ||
| self, readme_content: str, target_language: str, semaphore: asyncio.Semaphore | ||
| ) -> dict: | ||
| """Asynchronous request to translate README content via LLM.""" | ||
| prompt = PromptBuilder(self.config_loader).get_prompt_translate_readme(readme_content, target_language) | ||
| async with semaphore: | ||
| response = await self.model_handler.async_request(prompt) | ||
| response = process_text(response) | ||
| try: | ||
| result = json.loads(response) | ||
| except json.JSONDecodeError: | ||
| logger.warning(f"LLM response for '{target_language}' is not valid JSON, applying fallback") | ||
| result = { | ||
| "content": response.strip(), | ||
| "suffix": target_language[:2].lower(), | ||
| } | ||
|
|
||
| result["target_language"] = target_language | ||
| return result |
There was a problem hiding this comment.
А нет смысла всю эту асинхронную логику куда-то отдельно вынести и при необходимости переиспользовать? Она же вроде не специфична именно для translate-функциоальности?
There was a problem hiding this comment.
Да, в будущем надо будет перенести. Скорее всего в модуль с генерацией readme
nicl-nno
approved these changes
Oct 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Пока не стабильно переводятся названия секций README + В разработке добавление переведенных README на страницу github.
Примеры для https://github.com/Roman223/GAN_MFS
README_de.md
README_ru.md
README_zh.md