server can override and add custom command mappings #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rupurt
force-pushed
the
server-can-add-custom-commands-mapping
branch
from
361fa63 to
4d8398a
Compare
|
@pohmelie do you have any suggestions to get this merged? |
You need to move this from draft. "Draft" mode implies you are not ready for code review.
|
|
Done! 🍻 |
pohmelie
requested changes
Dec 23, 2024
setup.py
Outdated
| from setuptools import setup | ||
|
|
||
| if __name__ == "__main__": | ||
| setup() |
There was a problem hiding this comment.
Actually we do not need setupy.py, because of pyproject.toml file
There was a problem hiding this comment.
I originally thought I needed it for Nix but I found an override. I'll remove the commit
| @@ -660,6 +660,7 @@ def __init__( | |||
| data_ports=None, | |||
| encoding="utf-8", | |||
| ssl=None, | |||
| extra_commands_mapping={}, | |||
There was a problem hiding this comment.
This mapping should be added to documentation
rupurt
force-pushed
the
server-can-add-custom-commands-mapping
branch
from
4d8398a to
1308c03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The
Serverclass can override and add custom command mappings. I'm submitting this as a draft PR without unit tests to open the conversation around if this is a desirable change that will be accepted.Are there changes in behavior for the user?
No
Related issue number
None
Checklist