Unify checking whether depreciation warnings were emitted in tests #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #495 +/- ##
=======================================
Coverage 86.39% 86.39%
=======================================
Files 12 12
Lines 2088 2088
Branches 343 343
=======================================
Hits 1804 1804
Misses 218 218
Partials 66 66
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
thanks for the PR. with #703 this test method no longer relies on warnings, as the deprecated parts have been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR fixes a workaround introduced in e4cba8f for checking whether the
DepreciationWarnings were emitted.Previously, all warnings were recorded, while now only
DepreciationWarningtypes are.Are there changes in behavior for the user?
No, these changes affect tests only/
Checklist
CHANGESfolder<issue_id>.<type>(e.g.588.bugfix)issue_idchange it to the pr id after creating the PR.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.Fix issue with non-ascii contents in doctest text files.