Avoid dual-stack #516
Open
Avoid dual-stack #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenBSD doesn't support dual stack, that makes this broken on machine which hasn't got IPv6. Anyway, a machine which has IPv6, still, can't access IPv4 hosts.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #516 +/- ##
===========================================
- Coverage 100.00% 99.92% -0.08%
===========================================
Files 25 25
Lines 4999 5012 +13
===========================================
+ Hits 4999 5008 +9
- Misses 0 4 +4 ☔ View full report in Codecov by Sentry. |
|
Just because OpenBSD doesn't support dual-stack doesn't sound like a reason to disable the feature for all OS's that do. Can we detect the fact dual-stack doesn't work? Or opt in for this behaviour? |
|
@jlaine well, I can do something like this. |
Any suggestions on how to add OpenBSD to our CI pipeline? |
|
A few moths ago I did https://github.com/catap/shell whcih can be used as an example to add different system to github actions. |
catap
force-pushed
the
openbsd
branch
4 times, most recently
from
0059054
to
3aa752d
Compare
|
@jlaine 👋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenBSD doesn't support dual stack, that makes this broken on machine which hasn't got IPv6.
Anyway, a machine which has IPv6, still, can't access IPv4 hosts.