Improve connection establishment tests #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #529 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 5092 5092
=========================================
Hits 5092 5092 ☔ View full report in Codecov by Sentry. |
Before we attempt to refactor packet / datagram padding, we need to finely capture the current behaviour, so: - Add a detailed test for connection establishment without packet loss. - Exhaustively check the events emitted by client / server at each step with an `assertEvents` helper. - Check the unacknowledged sent packets at each step with an `assertSentPackets` helper. - Make use of the `client_and_server()` helper instead of manually spinning up client and server instances.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we attempt to refactor packet / datagram padding, we need to finely capture the current behaviour, so:
Add a detailed test for connection establishment without packet loss.
Exhaustively check the events emitted by client / server at each step with an
assertEventshelper.Check the unacknowledged sent packets at each step with an
assertSentPacketshelper.Make use of the
client_and_server()helper instead of manually spinning up client and server instances.