Skip to content

Add a README for ja #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bmf-san
Copy link
Contributor

@bmf-san bmf-san commented Jun 30, 2024

Description

Nice to meet you. I'm a Japanese software engineer who finds air very useful for go development. :)

I've added a Japanese README.

It seems that air is also often used in go development in Japan.

I am not a native speaker of English, but I am a native speaker of Japanese.
I have been careful not to change the meaning of the original text, and have tried to avoid free translation as much as possible.

Changes

  • Added README-ja.md
  • Added a link to README-ja.md to README.md

Supplement

When translating, I kept the following points in mind:

  • Use polite language
  • Do not add punctuation at the end of sentences in bullet points
  • Do not translate expressions that are likely to be understood in their original English
    • This applies to "Pull Request" and "Issue"
      • I thought that Japanese developers using Github would not need a Japanese translation

Issue

N/A

@bmf-san bmf-san marked this pull request as draft June 30, 2024 13:18
@bmf-san bmf-san force-pushed the feature/add-japanese-translation-readme branch 3 times, most recently from daa2963 to 1782b32 Compare June 30, 2024 13:28
@bmf-san bmf-san marked this pull request as ready for review June 30, 2024 13:29
@xiantang
Copy link
Collaborator

xiantang commented Jul 2, 2024

well done, let me review that.

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bmf-san
Copy link
Contributor Author

bmf-san commented Jul 30, 2024

@xiantang
How's the review for my recent commit coming along? 👀

@xiantang
Copy link
Collaborator

xiantang commented Jul 30, 2024

@xiantang How's the review for my recent commit coming along? 👀

日本語は苦手です🥹

@xiantang
Copy link
Collaborator

xiantang commented Mar 5, 2025

i will continue take a look this PR

@bmf-san bmf-san force-pushed the feature/add-japanese-translation-readme branch from 1782b32 to dc6c068 Compare March 6, 2025 06:28
@xiantang
Copy link
Collaborator

xiantang commented Mar 6, 2025

i translate back to my language, looks good to me totally

@xiantang
Copy link
Collaborator

xiantang commented Mar 6, 2025

could u add a space between English and Japanese?
for example:
this is the Chinese version
image

@bmf-san
Copy link
Contributor Author

bmf-san commented Mar 7, 2025

@xiantang
Thanks for your review :D
Understood, I've done!

@xiantang xiantang merged commit 326e87d into air-verse:master Mar 7, 2025
@bmf-san bmf-san deleted the feature/add-japanese-translation-readme branch March 7, 2025 08:46
caleb-fringer pushed a commit to caleb-fringer/air that referenced this pull request Mar 14, 2025
caleb-fringer pushed a commit to caleb-fringer/air that referenced this pull request Mar 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants