Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chart.js 2.8.0 and CSP compliance #54

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

evs-ch
Copy link

@evs-ch evs-ch commented Apr 1, 2019

We're using chartjs-ror with a strict CSP configuration. Chart.js 2.8 provides an option to disable css injection and provides a separate stylesheet.
This PR updates Chart.js, provides the stylesheet as an scss file and implements an option to disable css injection. I assumed a Chart.js version update might indicate a gem version update, too. I haven't found any issues with just dropping 2.8.0 in, tests run without errors.

Maybe there's a better way to implement this, I'm not married to this PR :)

@rickychilcott
Copy link

close #58

@rickychilcott
Copy link

Any update on getting this merged @airblade? This will fix CSP issues and update to Chart.js 2.8.0

@rickychilcott
Copy link

@evs-ch -- I'd also suggest you maybe become a maintainer? See #53

@airblade
Copy link
Owner

Unfortunately I don't use this any more and don't have the time to maintain it. I'm happy to hand it over to someone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants