Skip to content

Conversation

@archie94
Copy link

We are working on updating kotlin, ksp and the related dependencies in this project.
Still in the works and verifying the changes.
Please feel free to leave feedback.

cc @rossbacher


sourceCompatibility = 11

// apply plugin: 'org.jmailen.kotlinter'
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to self: revert.

Copy link
Collaborator

@rossbacher rossbacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much working on this! I just skimmed it, looks ok so far (other than being WIP) let me know when you think it is in a state that we can review.

resolver: Resolver?,
) {
try {
// source -> https://github.com/google/ksp/issues/2225
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you still planning on porting this?

@archie94
Copy link
Author

Thank you so much working on this! I just skimmed it, looks ok so far (other than being WIP) let me know when you think it is in a state that we can review.

Slowly working on this as time permits. My limited knowledge on ksp is making me slow.
Will notify here once done.

As we ran the tests several linting errors were highlighted; which from the looks of it is coming from updating ktlint; do you want those to be a focus of this PR?

@rossbacher
Copy link
Collaborator

Thank you so much working on this! I just skimmed it, looks ok so far (other than being WIP) let me know when you think it is in a state that we can review.

Slowly working on this as time permits. My limited knowledge on ksp is making me slow. Will notify here once done.

As we ran the tests several linting errors were highlighted; which from the looks of it is coming from updating ktlint; do you want those to be a focus of this PR?

You do not need to update ktlint as part of this PR, if you update ktlint the format changes also need to be addressed. All tests and checks need to pass.

@rossbacher
Copy link
Collaborator

@archie94 this #372 might help you, as it updates all the infra (but not xprocessing and not k2 support) to much newer versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants