-
Couldn't load subscription status.
- Fork 410
K2 #371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
K2 #371
Conversation
Signed-off-by: Arka Prava Basu <[email protected]>
Signed-off-by: Arka Prava Basu <[email protected]>
Signed-off-by: Arka Prava Basu <[email protected]>
Signed-off-by: Arka Prava Basu <[email protected]>
Signed-off-by: Arka Prava Basu <[email protected]>
enhancement: resolved CE errors & ran the sample project
Signed-off-by: Arka Prava Basu <[email protected]>
Signed-off-by: Arka Prava Basu <[email protected]>
Signed-off-by: Arka Prava Basu <[email protected]>
|
|
||
| sourceCompatibility = 11 | ||
|
|
||
| // apply plugin: 'org.jmailen.kotlinter' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: revert.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much working on this! I just skimmed it, looks ok so far (other than being WIP) let me know when you think it is in a state that we can review.
| resolver: Resolver?, | ||
| ) { | ||
| try { | ||
| // source -> https://github.com/google/ksp/issues/2225 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you still planning on porting this?
Slowly working on this as time permits. My limited knowledge on As we ran the tests several linting errors were highlighted; which from the looks of it is coming from updating |
You do not need to update ktlint as part of this PR, if you update ktlint the format changes also need to be addressed. All tests and checks need to pass. |
We are working on updating kotlin, ksp and the related dependencies in this project.
Still in the works and verifying the changes.
Please feel free to leave feedback.
cc @rossbacher