Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] Add ; for proper sql syntax #875

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Docs] Add ; for proper sql syntax #875

wants to merge 1 commit into from

Conversation

ken-zlai
Copy link

Summary

Was working thru the quickstart and noticed that one sql command was missing a ;

Why / Goal

Makes it easier for folks to copy/paste the code

Test Plan

  • Added Unit Tests
  • Covered by existing CI
  • Integration tested

Checklist

  • Documentation update

Reviewers

@ken-zlai ken-zlai changed the title Add ; for proper sql syntax [Docs] Add ; for proper sql syntax Nov 12, 2024
@pengyu-hou
Copy link
Collaborator

Thanks @ken-zlai

hzding621
hzding621 approved these changes Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@hzding621 hzding621 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Ken!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piyush-zlai piyush-zlai piyush-zlai approved these changes

@caiocamatta-stripe caiocamatta-stripe caiocamatta-stripe approved these changes

@hzding621 hzding621 hzding621 approved these changes

@pengyu-hou pengyu-hou pengyu-hou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ken-zlai @pengyu-hou @hzding621 @caiocamatta-stripe @piyush-zlai