Skip to content

Conversation

@piyush-zlai
Copy link
Collaborator

Summary

Add support for Flink UDF registration. This is currently marked as a todo in our Flink streaming integration - this PR brings the support to par with how we support & register udfs in Spark structured streaming.

Why / Goal

Bring Flink UDF support to parity with Spark.

Test Plan

  • Added Unit Tests
  • Covered by existing CI
  • Integration tested

Checklist

  • Documentation update

Reviewers

Copy link
Collaborator

@caiocamatta-stripe caiocamatta-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@piyush-zlai looks good. Is it worth adding a test case toSparkExpressionEvalFnTest or an integration test in FlinkJobIntegrationTest.scala?

@piyush-zlai
Copy link
Collaborator Author

@caiocamatta-stripe - thanks for the r. Could move the current tests over to the Flink test side. Might help me get around the flakes I've been seeing in the current test case setup as I've added some which might be conflicting with the other spark tests..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants