Skip to content

Conversation

tswitzer-netflix
Copy link
Contributor

Summary

This gets tests running successfully under bazel.

WIP: Currently only with --define spark_version=3.2

Why / Goal

They were not running and broken when I enabled them.

Test Plan

  • Added Unit Tests
  • Covered by existing CI
  • Integration tested

Checklist

  • Documentation update

Reviewers

@krisnaru
Copy link
Contributor

@tswitzer-netflix as you making progress, i would close my PR which opened long time ago, feel free to cherry-pick changes if needed. I will close my PR: #911 for time being. Thank you Tom.

@krisnaru krisnaru mentioned this pull request May 27, 2025
4 tasks
@nikhil-zlai
Copy link
Collaborator

nikhil-zlai commented May 27, 2025

if it is useful to you - we have a codemod script in our fork - that we used to re-write the tests into AnyFlatSpec

https://github.com/zipline-ai/chronon/blob/main/scripts/codemod/test_replace.py

Copy link
Collaborator

@nikhil-zlai nikhil-zlai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have a PR in our fork that upgrades bazel to 8.x and uses the latest rules_scala 7.0.

zipline-ai/chronon#958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants