Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added some changes in react readme file #2625

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
18 changes: 18 additions & 0 deletions react/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,9 @@ This style guide is mostly based on the standards that are currently prevalent i
- Always use JSX syntax.
- Do not use `React.createElement` unless you’re initializing the app from a file that is not JSX.
- [`react/forbid-prop-types`](https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/forbid-prop-types.md) will allow `arrays` and `objects` only if it is explicitly noted what `array` and `object` contains, using `arrayOf`, `objectOf`, or `shape`.
- Consider not using React memo,useMemo and useCallback hooks in the code unless there is no way to write the code.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? These hooks are critically important and should often be used - see https://attardi.org/why-we-memo-all-the-things/

- React specific file names should start with Capital letter where as Javascript specific file name can start with small letter.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

absolutely not; capitalization of values and filenames has nothing to do with React, and is a JavaScript-wide convention.

- Try to write folder specific components,so its easy to navigate.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate on this?


## Class vs `React.createClass` vs stateless

Expand All @@ -52,6 +55,21 @@ This style guide is mostly based on the standards that are currently prevalent i
}
```

```filenames in React
// bad
header.jsx

//good
Header.jsx


```filenames in Javascript
//bad
Header.js

//good
header.js

Comment on lines +58 to +72
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this; this is not a good thing to recommend nor will the airbnb guide likely ever recommend it.

And if you don’t have state or refs, prefer normal functions (not arrow functions) over classes:

```jsx
Expand Down