Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some dead links in the resource section of readme #2852

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Yash-Ambekar
Copy link

Fixed some dead links in the resource section of ReadMe when I was going through some of the linked resources.

README.md Outdated Show resolved Hide resolved
README.md Outdated
@@ -3931,7 +3931,7 @@ Other Style Guides

**Podcasts**

- [JavaScript Air](https://javascriptair.com/)
- [JavaScript Air](http://audio.javascriptair.com/)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this not available using https?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yash-Ambekar you marked this as resolved, but it's not resolved. can you answer the question?

@Yash-Ambekar
Copy link
Author

@ljharb @matheusfelipeog please review my changes and guide me how can I improve upon the changes.

@ljharb ljharb reopened this Oct 28, 2023
@cclypeatus
Copy link

The original link gives me a 502 Bad Gateway, while the new HTTP link gets blocked on Firefox in HTTPS only mode. One of these links might be a better replacement:

@ljharb ljharb marked this pull request as draft December 13, 2023 18:21
@Yash-Ambekar
Copy link
Author

The original link gives me a 502 Bad Gateway, while the new HTTP link gets blocked on Firefox in HTTPS only mode. One of these links might be a better replacement:

Yeah providing web archive links seems like a good idea to me. @ljharb please can you give your opinion on this.

@ljharb
Copy link
Collaborator

ljharb commented Dec 14, 2023

I'm fine with an archive.org link for any links that are dead; if we also want to reference a new URL that seems to have the same content, that's fine too.

@Yash-Ambekar Yash-Ambekar requested a review from ljharb December 17, 2023 07:53
@@ -3860,7 +3860,7 @@ Other Style Guides

- [Latest ECMA spec](https://tc39.github.io/ecma262/)
- [ExploringJS](https://exploringjs.com/)
- [ES6 Compatibility Table](https://compat-table.github.io/compat-table/es6/)
- [ES6 Compatibility Table](https://kangax.github.io/compat-table/es6/)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be reverted, the compat table lives in an org now

@@ -3931,7 +3931,7 @@ Other Style Guides

**Podcasts**

- [JavaScript Air](https://javascriptair.com/)
- [JavaScript Air](https://web.archive.org/web/20190626004622/https://javascriptair.com/)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both the links point to the same source , so why this url change required ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the website was down before, but is back up now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants