Add generalized Lottie Feature Flags API #2512
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpeal
approved these changes
Jun 17, 2024
gpeal
reviewed
Jun 17, 2024
gpeal
reviewed
Jun 26, 2024
| return lottieDrawable.isFeatureFlagEnabled(LottieFeatureFlags.FeatureFlag.MergePathsApi19); | ||
| } | ||
|
|
||
| public void enableFeatureFlag(LottieFeatureFlags.FeatureFlag flag, boolean enable) { |
There was a problem hiding this comment.
Could you add docs here since this is a new public API?
I would make it extra explicit that people validate that opted in features look acceptable across all supported API levels.
| } | ||
|
|
||
| /** | ||
| * Enable this to get merge path support for devices running KitKat (19) and above. | ||
| * Deprecated: Use enableFeatureFlag(LottieFeatureFlags.FeatureFlag.MergePathsApi19, enable) |
There was a problem hiding this comment.
You can use @deprecated and @link for proper javadoc syntax.
|
|
||
| import java.util.HashSet; | ||
|
|
||
| public class LottieFeatureFlags { |
There was a problem hiding this comment.
Let's move LottieFeatureFlags to a package that's package-private so we don't expose this class in the public API and make FeatureFlag a top-level public enum LottieFeatureFlag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there are individual methods for enabling and disabling Merge Paths in Lottie. This PR aims to generalize these functions as we consider adding more features guarded behind opt-in flags.
See jbeta51#2 for draft comments.