-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[a11y] Changing logic of how reduce motion options are set to match it with lottie iOS #2536
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
dbe7c7e
Changing logic of how reduce motion options are set to match it with …
393dd0d
Merge remote-tracking branch 'upstream/master' into pranay-reducemoti…
bb2d811
putting the orignal API back to maintain backward compatibility.
86f2531
updating logic to consider `ignoreSystemAnimationsDisabled` first
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
...a/com/airbnb/lottie/configurations/reducemotion/IgnoreDisabledSystemAnimationsOption.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
package com.airbnb.lottie.configurations.reducemotion; | ||
|
||
import android.content.Context; | ||
|
||
/** | ||
* Allows ignoring system animations settings, therefore allowing animations to run even if they are disabled. | ||
*/ | ||
public class IgnoreDisabledSystemAnimationsOption implements ReducedMotionOption { | ||
|
||
@Override | ||
public ReducedMotionMode getCurrentReducedMotionMode(Context context) { | ||
return ReducedMotionMode.STANDARD_MOTION; | ||
} | ||
} |
16 changes: 16 additions & 0 deletions
16
lottie/src/main/java/com/airbnb/lottie/configurations/reducemotion/ReducedMotionMode.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
package com.airbnb.lottie.configurations.reducemotion; | ||
|
||
|
||
public enum ReducedMotionMode { | ||
/** | ||
* The default behavior where Lottie animations play normally with no overrides. | ||
* By default this mode is used when {@link com.airbnb.lottie.utils.Utils#getAnimationScale(Context)} is not 0. | ||
*/ | ||
STANDARD_MOTION, | ||
|
||
/** | ||
* Lottie animations with a "reduced motion" marker will play that marker instead of any other animations. | ||
* By default this mode is used when {@link com.airbnb.lottie.utils.Utils#getAnimationScale(Context)} == 0. | ||
*/ | ||
REDUCED_MOTION | ||
} |
11 changes: 11 additions & 0 deletions
11
lottie/src/main/java/com/airbnb/lottie/configurations/reducemotion/ReducedMotionOption.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
package com.airbnb.lottie.configurations.reducemotion; | ||
|
||
import android.content.Context; | ||
|
||
public interface ReducedMotionOption { | ||
|
||
/** | ||
* Returns the current reduced motion mode. | ||
*/ | ||
ReducedMotionMode getCurrentReducedMotionMode(Context context); | ||
} |
28 changes: 28 additions & 0 deletions
28
...rc/main/java/com/airbnb/lottie/configurations/reducemotion/SystemReducedMotionOption.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
package com.airbnb.lottie.configurations.reducemotion; | ||
|
||
import android.content.Context; | ||
import com.airbnb.lottie.utils.Utils; | ||
|
||
/** | ||
* Lottie animations with a "reduced motion" marker will play that marker instead of any other animations. | ||
* This class uses {@link com.airbnb.lottie.utils.Utils#getAnimationScale(Context)} to determine if animations are disabled | ||
* and if it should play the reduced motion marker. | ||
* | ||
* If the animation is provided a "reduced motion" | ||
* marker name, they will be shown instead of the first or last frame. Supported marker names are case insensitive, and include: | ||
* - reduced motion | ||
* - reducedMotion | ||
* - reduced_motion | ||
* - reduced-motion | ||
*/ | ||
public class SystemReducedMotionOption implements ReducedMotionOption { | ||
|
||
@Override | ||
public ReducedMotionMode getCurrentReducedMotionMode(Context context) { | ||
if (Utils.getAnimationScale(context) != 0f) { | ||
return ReducedMotionMode.STANDARD_MOTION; | ||
} else { | ||
return ReducedMotionMode.REDUCED_MOTION; | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing an existing public API is tricky. At the very least, we'll need to deprecate this and provide a graceful fallback. Ideally, its behavior would remain the same (scope IgnoreDisabledSystemAnimations() to this view if possible).
It can be fully removed after a few releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gpeal make sense, added the original API back. I also marked it as deprecated so folks can switch to new API