-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[a11y] Changing logic of how reduce motion options are set to match it with lottie iOS #2536
Changes from 3 commits
dbe7c7e
393dd0d
bb2d811
86f2531
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,6 +33,7 @@ | |
import androidx.annotation.RestrictTo; | ||
|
||
import com.airbnb.lottie.animation.LPaint; | ||
import com.airbnb.lottie.configurations.reducemotion.ReducedMotionMode; | ||
import com.airbnb.lottie.manager.FontAssetManager; | ||
import com.airbnb.lottie.manager.ImageAssetManager; | ||
import com.airbnb.lottie.model.Font; | ||
|
@@ -1244,7 +1245,8 @@ boolean isAnimatingOrWillAnimateOnVisible() { | |
} | ||
|
||
private boolean animationsEnabled() { | ||
return systemAnimationsEnabled || ignoreSystemAnimationsDisabled; | ||
return (systemAnimationsEnabled || ignoreSystemAnimationsDisabled) && | ||
L.getReducedMotionOption().getCurrentReducedMotionMode(getContext()) == ReducedMotionMode.STANDARD_MOTION; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If I'm reading this correctly, if you set
The predicate becomes (false || true) && (REDUCED == STANDARD) which would be false. I think this may also read easier if you treat
Just off the top of my head, I think this is correct and easier to read. Is that right? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. you are right. Ideally There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I changed it to this
We still need to consider old |
||
} | ||
|
||
/** | ||
|
@@ -1256,7 +1258,10 @@ private boolean animationsEnabled() { | |
* - reducedMotion | ||
* - reduced_motion | ||
* - reduced-motion | ||
* | ||
* @deprecated Use {@link com.airbnb.lottie.configurations.reducemotion.ReducedMotionOption} instead and set them on the {@link LottieConfig} | ||
*/ | ||
@Deprecated | ||
public void setSystemAnimationsAreEnabled(Boolean areEnabled) { | ||
systemAnimationsEnabled = areEnabled; | ||
} | ||
|
@@ -1269,7 +1274,10 @@ public void setSystemAnimationsAreEnabled(Boolean areEnabled) { | |
* Defaults to false. | ||
* | ||
* @param ignore if true animations will run even when they are disabled in the system settings. | ||
* @deprecated Use {@link com.airbnb.lottie.configurations.reducemotion.IgnoreDisabledSystemAnimationsOption} | ||
* instead and set them on the {@link LottieConfig} | ||
*/ | ||
@Deprecated | ||
public void setIgnoreDisabledSystemAnimations(boolean ignore) { | ||
ignoreSystemAnimationsDisabled = ignore; | ||
} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
package com.airbnb.lottie.configurations.reducemotion; | ||
|
||
import android.content.Context; | ||
|
||
/** | ||
* Allows ignoring system animations settings, therefore allowing animations to run even if they are disabled. | ||
*/ | ||
public class IgnoreDisabledSystemAnimationsOption implements ReducedMotionOption { | ||
|
||
@Override | ||
public ReducedMotionMode getCurrentReducedMotionMode(Context context) { | ||
return ReducedMotionMode.STANDARD_MOTION; | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
package com.airbnb.lottie.configurations.reducemotion; | ||
|
||
|
||
public enum ReducedMotionMode { | ||
/** | ||
* The default behavior where Lottie animations play normally with no overrides. | ||
* By default this mode is used when {@link com.airbnb.lottie.utils.Utils#getAnimationScale(Context)} is not 0. | ||
*/ | ||
STANDARD_MOTION, | ||
|
||
/** | ||
* Lottie animations with a "reduced motion" marker will play that marker instead of any other animations. | ||
* By default this mode is used when {@link com.airbnb.lottie.utils.Utils#getAnimationScale(Context)} == 0. | ||
*/ | ||
REDUCED_MOTION | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
package com.airbnb.lottie.configurations.reducemotion; | ||
|
||
import android.content.Context; | ||
|
||
public interface ReducedMotionOption { | ||
|
||
/** | ||
* Returns the current reduced motion mode. | ||
*/ | ||
ReducedMotionMode getCurrentReducedMotionMode(Context context); | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
package com.airbnb.lottie.configurations.reducemotion; | ||
|
||
import android.content.Context; | ||
import com.airbnb.lottie.utils.Utils; | ||
|
||
/** | ||
* Lottie animations with a "reduced motion" marker will play that marker instead of any other animations. | ||
* This class uses {@link com.airbnb.lottie.utils.Utils#getAnimationScale(Context)} to determine if animations are disabled | ||
* and if it should play the reduced motion marker. | ||
* | ||
* If the animation is provided a "reduced motion" | ||
* marker name, they will be shown instead of the first or last frame. Supported marker names are case insensitive, and include: | ||
* - reduced motion | ||
* - reducedMotion | ||
* - reduced_motion | ||
* - reduced-motion | ||
*/ | ||
public class SystemReducedMotionOption implements ReducedMotionOption { | ||
|
||
@Override | ||
public ReducedMotionMode getCurrentReducedMotionMode(Context context) { | ||
if (Utils.getAnimationScale(context) != 0f) { | ||
return ReducedMotionMode.STANDARD_MOTION; | ||
} else { | ||
return ReducedMotionMode.REDUCED_MOTION; | ||
} | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing an existing public API is tricky. At the very least, we'll need to deprecate this and provide a graceful fallback. Ideally, its behavior would remain the same (scope IgnoreDisabledSystemAnimations() to this view if possible).
It can be fully removed after a few releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gpeal make sense, added the original API back. I also marked it as deprecated so folks can switch to new API