-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancements to JIRA v1 output #1311
base: release-4-0-0
Are you sure you want to change the base?
Conversation
Bumps [httplib2](https://github.com/httplib2/httplib2) from 0.18.1 to 0.19.0. - [Release notes](https://github.com/httplib2/httplib2/releases) - [Changelog](https://github.com/httplib2/httplib2/blob/master/CHANGELOG) - [Commits](httplib2/httplib2@v0.18.1...v0.19.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…1303) Co-authored-by: Ryxias <[email protected]>
* Add victorops as an output in streamalert. * linting fixes. * Update test_output_base to include victorops * Missing comma Co-authored-by: Zach Zeid <[email protected]> Co-authored-by: Ryxias <[email protected]>
* Copy Existing Jira provider and update test + imports for new provider name * Update app collector for v2 * Update test use-cases + fix b64encode * Update docs * Lint: * Decode b64 object Co-authored-by: Ryxias <[email protected]>
* Update cloudtrail schema to 1.08 * Update OPTK Co-authored-by: Ryxias <[email protected]>
Bumps [cryptography](https://github.com/pyca/cryptography) from 3.0 to 3.2. - [Release notes](https://github.com/pyca/cryptography/releases) - [Changelog](https://github.com/pyca/cryptography/blob/master/CHANGELOG.rst) - [Commits](pyca/cryptography@3.0...3.2) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ryxias <[email protected]>
* bump cffi to resolve install issues on osx big sur * define idna version to resolve conflict Co-authored-by: Dean Illfeld <[email protected]> Co-authored-by: Ryxias <[email protected]>
I really like the changes here to the aggregation filter and also the additional fields. To confirm was the intent in the CC to see if they should also be added to the Jira_v2 output. Also in hindsight I wonder if supporting both auth methods in the same output behind a boolean may be better than two distinct outputs. |
Yeah it was kind of an "FYI" since I knew you wrote a lot of the JIRA v2 integration. Admittedly we didn't sync the v2 internally yet so I actually forgot it existed on the OSS repo; only just noticed it when I synced these JIRA changes out. And yeah, I took a cursory glance over the JIRA integration and I see the main difference is the auth; v1 uses username/password login whereas v2 uses api key in basic auth header. Since they both use REST API v1/v2 I think would be worth DRYING it out. I'll think about doing that if I have time |
PS this is 🔥 Just pulled this in & Dry'd out the config in #1333 |
to: @ryandeivert @chunyong-lin
cc: @gavinelder
cc: @airbnb/streamalert-maintainers
Changes
ClientSide SSL Verification
To enable this, simply put
yes
in the newssl_verify
output parameter.Aggregation Additional Filter
Can also use other fields like
created > startOfWeek(-1w) AND status != Resolved
or the like. It depends on your JIRA project's specific configurations. You might have some crazy custom field likecustom_field_10101 = "Low"
. Etc.To enable this, simply put the query string into the
aggregation_additional_jql
output parameter.Additional Fields
To enable this, provide the json-encoded string representation of the dict. Because the parameter store stores everything as a JSON string you'll have to escape quotes.
Testing
Deployed internally