Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source-track-pms: rename kebab case streams to snake case, alphabetize streams #51593

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

blakeflei
Copy link
Contributor

What

Stream names were kebab case leading to destination kebab case tables, which is not a best practice (and not permitted by some databases). We tested this for Snowflake, but should be applicable to any database destination.

Also, with 77 streams, alphabetizing becomes important for finding/editing streams in the Airbyte UI. Streams have been alphabetized.

This is a breaking change, but was versioned as minor because this connector is not yet considered mature.

Addresses Issue #5158

How

Streams have been renamed & sorted in manifest.yml, version updated in metadata.yaml, docs updated. All streams have been tested.

Review guide

none

User Impact

Previous kebab case tables generated by kebab case strings will no longer update. Connections need to be rebuilt.

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

Copy link

vercel bot commented Jan 16, 2025

Someone is attempting to deploy a commit to the Airbyte Growth Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Jan 16, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jsonschema.exceptions.ValidationError: The manifest version 6.5.2 is greater than the airbyte-cdk package version (5.14.0). Your manifest may contain features that are not in the current CDK version.

@blakeflei blakeflei force-pushed the blakeflei/source-track-pms-stream-fix branch from e1acafc to 2d0789d Compare January 17, 2025 16:59
@blakeflei blakeflei temporarily deployed to community-ci-auto January 17, 2025 16:59 — with GitHub Actions Inactive
@marcosmarxm marcosmarxm self-assigned this Jan 17, 2025
@natikgadzhi
Copy link
Contributor

jsonschema.exceptions.ValidationError: The manifest version 6.5.2 is greater than the airbyte-cdk package version (5.14.0). Your manifest may contain features that are not in the current CDK version.

@marcosmarxm this happens when the version of the source-declarative-manifest image in baseImage in metadata.yaml is LOWER than the version: value of the manifest.yaml file.

I.e. the library that is bundled in the docker image is lower than the version you request in the manifest.

I suggest bumping the metadata base image to the new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation community connectors/source/track-pms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants