-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
source-track-pms: rename kebab case streams to snake case, alphabetize streams #51593
base: master
Are you sure you want to change the base?
source-track-pms: rename kebab case streams to snake case, alphabetize streams #51593
Conversation
Someone is attempting to deploy a commit to the Airbyte Growth Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jsonschema.exceptions.ValidationError: The manifest version 6.5.2 is greater than the airbyte-cdk package version (5.14.0). Your manifest may contain features that are not in the current CDK version.
e1acafc
to
2d0789d
Compare
@marcosmarxm this happens when the version of the I.e. the library that is bundled in the docker image is lower than the version you request in the manifest. I suggest bumping the metadata base image to the new one. |
What
Stream names were kebab case leading to destination kebab case tables, which is not a best practice (and not permitted by some databases). We tested this for Snowflake, but should be applicable to any database destination.
Also, with 77 streams, alphabetizing becomes important for finding/editing streams in the Airbyte UI. Streams have been alphabetized.
This is a breaking change, but was versioned as minor because this connector is not yet considered mature.
Addresses Issue #5158
How
Streams have been renamed & sorted in manifest.yml, version updated in metadata.yaml, docs updated. All streams have been tested.
Review guide
none
User Impact
Previous kebab case tables generated by kebab case strings will no longer update. Connections need to be rebuilt.
Can this PR be safely reverted and rolled back?