Skip to content

✨ Source Facebook Marketing: Update to version 21 of the API#52032

Merged
Danylo Jablonski (DanyloGL) merged 28 commits intomasterfrom
maxi297/facebook-marketing-update-to-api-version-21
Jan 29, 2025
Merged

✨ Source Facebook Marketing: Update to version 21 of the API#52032
Danylo Jablonski (DanyloGL) merged 28 commits intomasterfrom
maxi297/facebook-marketing-update-to-api-version-21

Conversation

@maxi297
Copy link
Copy Markdown
Contributor

What

Following #50852

How

Review guide

User Impact

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 3:24pm

@bazarnov Baz (bazarnov) self-requested a review January 24, 2025 14:03
@bazarnov
Copy link
Copy Markdown
Contributor

Maxime Carbonneau-Leclerc (@maxi297) I believe we should be reflecting the spec change in this file as well: https://github.com/airbytehq/airbyte/blob/bnchrch/oauth/add-docs/airbyte-integrations/connectors/source-facebook-marketing/integration_tests/spec.json#L2

Copy link
Copy Markdown
Contributor

@bazarnov Baz (bazarnov) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unblocking the merge, after the changes request. This is not a final approval.

@maxi297
Copy link
Copy Markdown
Contributor Author

Maxime Carbonneau-Leclerc (maxi297) commented Jan 29, 2025

/approve-regression-tests done before the previous comment

Check job output.

✅ Approving regression tests

@DanyloGL Danylo Jablonski (DanyloGL) deleted the maxi297/facebook-marketing-update-to-api-version-21 branch January 29, 2025 17:11
Stephane Geneix (stephane-airbyte) pushed a commit that referenced this pull request Feb 4, 2025
Co-authored-by: jake horban <j@portal.ai>
Co-authored-by: jake horban <jake.horban@gmail.com>
Co-authored-by: Danylo Jablonski <150933663+DanyloGL@users.noreply.github.com>
Co-authored-by: daniel.i.jablonski <daniel.i.jablonski@globallogic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/facebook-marketing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants