Lib restructure #1120
Lib restructure #1120
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1120 +/- ##
==========================================
+ Coverage 85.48% 85.55% +0.06%
==========================================
Files 305 293 -12
Lines 6675 6706 +31
==========================================
+ Hits 5706 5737 +31
Misses 969 969
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
…e other tests and fixed black.
…f the backend lib, the model type, backbone name and the number of classes (optionaly configuration for the backbone and the model can be supplied). Some of the backbon files have been modified to work with the build_model function, the util files (that contained one or two functions where merged into the main backbone files to reduce clutter and remove edgecases in the handeling of model/backbone creation.
icevision/utils/model_creation.py
Outdated
|
|
||
|
|
||
| def build_model( | ||
| backend_lib_name: str, |
There was a problem hiding this comment.
Wdyt about simplifying the argument name by using:
lib_name, model_name instead of backend_lib_name and model_type_name
Also, would it be better to pass a dictionary instead of argument. Maybe using a dict, we will loose auto-completion.
There was a problem hiding this comment.
Sure I will change the naming. I think keeping arguments is better as we have autocompletion with that approach and users still can use dicts if they want to and just unpack them with **dict into the function call.
…to model_name and lib_name.
His PR refactors ross and ultralytics to the new structure.