Optimize succinctBytes, succinctDuration #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
wendigo
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the conversion of time durations and data sizes by updating the succinct methods in Duration and DataSize.
- Improve succinctDuration in Duration.java to dynamically select the most succinct time unit using a helper method.
- Update DataSize.java to leverage a static succinctUnit method and add an early return in to(Unit) for performance gains.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main/java/io/airlift/units/Duration.java | Updates conversion logic and introduces conversion helpers to optimize succinctDuration. |
| src/main/java/io/airlift/units/DataSize.java | Refactors succinct methods to use static unit selection and optimizes conversion checks. |
wendigo
force-pushed
the
serafin/optimize-succinct-bytes
branch
from
8a8001f to
a34e15c
Compare
wendigo
force-pushed
the
serafin/optimize-succinct-bytes
branch
from
a34e15c to
c9920e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.