Repository navigation
fix(mobile): tall iOS code blocks with long lines show their code - #228
Merged
Merged
Conversation
Ports upstream 0ca50a6f1e (#33243) into Onicode's own Enriched Markdown build: aislopware/enriched-markdown@9c558b5c (1.2.0-oni.20) cherry-picks pingdotgg/enriched-markdown#15, which draws code panes too big for one backing store through a CATiledLayer. Upstream e4f066da21 (#36461) was already in oni.19 with the identical blockquote preview change; both ledger rows now record the port. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On iOS, a tall code block with long lines showed its header and reserved its height, but the code pane stayed empty. Upstream fixed this (0ca50a6f1e, #33243) and the long-pressed blockquote overlap (e4f066da21, #36461) by shipping new builds of T3 Code's Enriched Markdown tarball, so the upstream sync skipped both: Onicode ships its own build from aislopware/enriched-markdown.
This ports the fixes into that fork:
1.2.0-oni.20, tagoni-v1.2.0-oni.20) cherry-picks fix(ios): tall code blocks with long lines no longer draw an empty pane pingdotgg/enriched-markdown#15. The code pane now draws through a canvas that switches to aCATiledLayeronce it is too big for one backing store. The pane's view was sized to the whole block, so its backing store needed more memory than iOS would allocate.oni.19(aislopware/enriched-markdown@8f75ee5a). ItsENRMBlockquoteContainerView.mmis byte-identical to upstream'st3.18-16db4c75, so no source change was needed.The new tarball's contents match upstream's
t3.18-16db4c75apart from the fork metadata (oni-fork.json,package.json). The tarball,package.json,pnpm-workspace.yaml, the lockfile anddeps/README.mdmove tooni.20, and the old tarball is removed. Both ledger rows go fromskiptotake. Native clients need a rebuild because the fingerprint changes.Before / after (iPhone 17 simulator, iOS 27.2)
Replay (dev) turn with a 900-line block of roughly 400-character lines, and a blockquote.
oni.19)oni.20)oni.19)vp run check:changedpasses.Ported with Claude Opus 5.5 in Claude Code (Onicode).
🤖 Generated with Claude Code