Repository navigation
chore(upstream-sync): port 6 t3code commits - #450
Merged
Merged
Conversation
…dy ran Cursor (#39246) Ported from pingdotgg/t3code@106a1e03b7. Adapted: Onicode runs @cursor/sdk 1.4.0, so the model-list cache refetch went into patches/@cursor__sdk@1.4.0.patch instead of upstream's 1.3.1 patch.
…vider config (#39247) Ported from pingdotgg/t3code@c0b1d32c97.
…s (#39235) Ported from pingdotgg/t3code@2fe74b00fa. Co-authored-by: Julius Marminge <julius0216@outlook.com>
Onicode already translates every quote and port key this commit translates.
…253) Ported from pingdotgg/t3code@9246c3235e. Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…nal closed (#39260) Ported from pingdotgg/t3code@80cf4f7945. Co-authored-by: Julius Marminge <julius0216@outlook.com>
…extracted again Follow-up to b961674 (port of pingdotgg/t3code@9246c3235e): the worker output changed, so the extractor version moves to 3 and old v2 sidecars with ANSI codes are not reused. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Follow-up to 3b2043d (port of pingdotgg/t3code@106a1e03b7): the index headers of the three edited dist files now match the patched output. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…est of the app Ported from pingdotgg/t3code@d1f8636f49 (adapted): Onicode already translated every key in that commit; only the six mobile French quote messages that used "tu" take upstream's "vous" wording. Co-authored-by: Julius Marminge <julius0216@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the 6 new upstream t3code commits (106a1e03b7..80cf4f7945): a Cursor model-list fix, workspace models in MCP delegation, a forced index for shell reads, notebook output cleanup, a terminal drawer fix, and French wording.
Risky commits
<file>.v2.txt). I kept Onicode's sidecar path and took upstream's stricter output asserts. Review found the port also needed an extractor version bump, so notebooks extracted before this fix don't keep reusing the old text with ANSI codes. Follow-up 124f540 movesDocumentTextto version 3. The notebook test now seeds a styled.v2.txtand fails on version 2.fruses "vous" (122 vs 30 imperatives). Those six take upstream's formal wording (76d174f).@cursor/sdk@1.3.1, which Onicode doesn't have (MISSING). Onicode runs 1.4.0, which has the same model-list cache bug. I applied the same refetch-on-miss change to the minifieddist/bundled,dist/cjsanddist/esmcode inpatches/@cursor__sdk@1.4.0.patch, using 1.4.0's own identifiers. The new adapter test fails on main ("Cannot use this model: composer-2.5") and passes with the patch. 4cd9b0d refreshes the patch's blob headers.Routine commits
orchestration_v2_projection_turn_items_shell_pending_idxexists in Onicode'sShellIndexesmigration with a matching predicate.Adopt-or-keep decisions
<file>.txt: Onicode's version re-extracts text an older extractor wrote. Upstream's fix exposed exactly that need here.Skipped
None. d1f8636f49 was first recorded as a skip (7483e76) and then changed to an adapted take (76d174f).
E2E scenarios
None in this batch.
Follow-ups
Queued in the follow-up queue (
## From sync chore/upstream-sync-20261120-0206). A batch fix thread (Batched fixes: Force stop/session release, PR watch, mobile RTL…, queue 2026-11-20 00:35) is still running, so no new thread was started. The next batch takes these:orchestrator_capabilitiesnow scans every enabled provider for an unscanned folder and waits for the slowest (OrchestratorMcpService.ts~2569-2588). It ignores project enablement, and only OpenCode supplies workspace models. A Claude or Codex orchestrator in a fresh worktree can wait on a Codex app-server probe (20 s timeout), and each scan republishes the provider list to older clients.Left to upstream (OpenCode only, the only driver with workspace models). All four come from c0b1d32c97:
delegate_taskskips the workspace retry.oni_thread_launchinto a new worktree validates against the project root.model_unavailableretry doesn't force a fresh scan.Review findings
Codex gpt-6.2-astra (high) and a Claude Opus subagent reviewed independently, using the same brief.
orchestrator_capabilitiesscans unrelated providers. Raised by both. This is upstream's design, in shared core. Queued (see above).indexblob headers in the hand-edited Cursor patch. Raised by both, as a nit (pnpm ignores them). Fixed (4cd9b0d). The headers now match the installed patched files.outputTextjoins all fragments before the 1M-character budget applies. Raised by Codex. Dismissed: the isolated worker has already parsed the whole notebook JSON, and the join adds one linear pass over data already in memory.vp run check:changedpasses on the final head. The focused suites pass: the cursor adapter test, the MCP service, toolkit and handler suites,ProjectionStore,userInputAttachments, attachment upload, store and claims, andterminalUiStateStore.Done with Claude Opus 5.5 in Claude Code, reviewed by Codex gpt-6.2-astra and Claude Opus 5.5.
🤖 Generated with Claude Code