Repository navigation
chore(upstream-sync): port 29 t3code commits - #452
Merged
Merged
Conversation
… packs (#39264) Ported from pingdotgg/t3code@1852121afa.
…ithout model controls (#23586) Ported from pingdotgg/t3code@5f8ab374af.
Marketing homepage copy only.
Ported from pingdotgg/t3code@21df2269bd. Co-authored-by: Julius Marminge <julius0216@outlook.com>
Onicode already fixed this race by waiting for Chromium's DevToolsActivePort file.
Ported from pingdotgg/t3code@c8625cafce. Co-authored-by: Julius Marminge <julius0216@outlook.com>
…519) Ported from pingdotgg/t3code@ff4197c480. Co-authored-by: SAPHID <saphid@users.noreply.github.com> Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
… actions (#31545) Ported from pingdotgg/t3code@42d2387285. Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ts do Follow-up to the port of pingdotgg/t3code@1852121afa: upstream's new adoptPrivateObjects duplicated Onicode's checkpoint object publication with weaker guarantees (fanout directories ignored core.sharedRepository, a pack could land before its index, an incomplete pack pair was moved). Both now share publishPrivateObjects. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ported from pingdotgg/t3code@910c1a8df9. Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…als (#35343) Ported from pingdotgg/t3code@3c08684f1d. Co-authored-by: Julius Marminge <julius0216@outlook.com>
…hot (#39269) Ported from pingdotgg/t3code@4e39664248.
…7978) Ported from pingdotgg/t3code@7922611cee. The marketing site change is dropped; Onicode does not ship that file. Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
Ported from pingdotgg/t3code@0240eac9da. Co-authored-by: Julius Marminge <julius0216@outlook.com>
…7020) Ported from pingdotgg/t3code@cdf5a6c0fc. Co-authored-by: 尤嘉兴 <youjiaxing@dianchu.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…e (#35307) Ported from pingdotgg/t3code@031dd1a818. Signed-off-by: bettercallcaleb <121191527+bettercallcaleb@users.noreply.github.com> Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ojection read span (#39284) Ported from pingdotgg/t3code@44e3f42e69. Onicode keeps its /rename title handling around the new findThread lookup. Co-authored-by: mInrOz <14320143+mInrOz@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
Ported from pingdotgg/t3code@a4d0151700. The scenario presses ControlOrMeta+f like the other desktop Find scenarios. Co-authored-by: Julius Marminge <julius0216@outlook.com>
…e (#39294) Ported from pingdotgg/t3code@55e379bb96. Co-authored-by: Martin Bergo <14320143+mInrOz@users.noreply.github.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…s (#39285) Ported from pingdotgg/t3code@9f4d25495d.
Ported from pingdotgg/t3code@5bc2d512e4. The scenario presses ControlOrMeta+f like the other desktop Find scenarios. Co-authored-by: Julius Marminge <julius0216@outlook.com>
…der reuses its session (#27517) Ported from pingdotgg/t3code@d32df2d34c. Onicode's scheduled fresh session test now gives its alternate Codex adapter a new native id per replacement, as real Codex does; it returned the same id and so tripped the new reused-session check. Co-authored-by: TinBane <363069+TinBane@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: maria-rcks <maria@kuuro.net>
…29196) Ported from pingdotgg/t3code@61085457d7. Co-authored-by: maria-rcks <maria@kuuro.net>
…shared session (#32396) Ported from pingdotgg/t3code@800b0748bc. Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ults (#26664) Ported from pingdotgg/t3code@1e70210250.
Ported from pingdotgg/t3code@1e9f4c45c3. Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
…ot Found (#38210) Ported from pingdotgg/t3code@6d05c5f496. The scenario presses ControlOrMeta+p like the other desktop file-picker scenarios. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: GPT 6.1 Sol <codex@openai.com>
Ported from pingdotgg/t3code@0f32645852. Onicode first skipped this as Windows-only, but node --watch-path=../../packages restarts the dev server on macOS and Linux too whenever anything writes under packages/*/node_modules (the vitest cache, vp i). Upstream's watcher watches only each package's src and package.json. Onicode has no dev:built script, so that line is left out. Co-authored-by: Julius Marminge <julius0216@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports 29 upstream t3code commits in two bundles: 1852121afa..42d2387285 (6 taken, 2 skipped) and 910c1a8df9..0f32645852 (20 taken, 1 skipped). The first bundle:
session/loadreply arrives lateThe second bundle:
packages/*/node_modulespreview_resizeon hidden desktop tabs, ACP image previews, Antigravity compaction, the SSH missing-tarmessage, no Git spawn in a removed worktree, a quieter projection read span, triage filing, Simplified Chinese stringsRisky commits
adoptPrivateObjectsto publish the objects. It duplicated Onicode's checkpoint object publication with weaker guarantees:core.sharedRepository.packcould land before its.idxapps/server/src/vcs/gitObjectPublication.tsaspublishPrivateObjects. Checkpoints and the status fetch both use it, and upstream's copy is gone.tmp_objdir-onicode-.useStableCallbackafterhandleThreadContextMenu, so Onicode's hook order is untouched. "does not re-render thread rows when the sidebar renders with nothing changed" passes, and so doesSidebar.drag.browser.test.tsx.Second bundle:
filePreview.test.ts.zh.tshunk is dropped, because Onicode has no marketing site. The app strings are taken.ProviderEventIngestor.ts, resolved by hand. The lookup uses the newfindThread, and Onicode's/renametitle-ownership logic around it is kept (upstream has nothing like it).ProviderSwitch.integration.test.tsfixture options; both Onicode'sholdRollbackand upstream'sbeforeForcedNativeThreadare kept.nativeThreadRefon replacement, so the new error fires only for providers that really reuse their session.thread.itemCount, which the contract already requires, so older linked environments still work.via-triagelabel yet, so the template cannot apply it (this predates the sync).apps/server/package.json: Onicode has nodev:built, so that line is left out.Routine commits
oni_thread_launchtakesclientRequestIdin Onicode).Second bundle, taken as is unless noted:
preview_resizesizes hidden desktop tabs without a snapshotAdopt-or-keep decisions
Kept Onicode's checkpoint object publication over upstream's new
adoptPrivateObjects. Onicode's version preserves shared-repository fanout permissions, links metadata before the pack, publishes only complete pack pairs, and treats an existing object as success. The status fetch now reuses it.Kept Onicode's DevToolsActivePort wait over upstream's reserved port (2ab3b7f59c). Onicode's 578ef81 waits for the port Chromium actually bound. Upstream releases a reserved port before launch, so another process can take it in between.
Adopted upstream's dev watcher over Onicode's
node --watch-path=../../packages(0f32645852).--watch-path=../../packagesalso coverspackages/*/node_modules.node_modules/.vite/results.json. Vitest's cache andvp iwrite there, so they restartedvp run dev:server.apps/server/scripts/dev.tswatches only each package'ssrcandpackage.json. A probe with the new script ignored thenode_moduleswrite and restarted once on asrcchange.Kept Onicode's
/renametitle handling inProviderEventIngestor(44e3f42e69), since upstream has no equivalent, and took upstream'sfindThreadlookup.Skipped
desktopUpdateChannelOfor channel switch.E2E scenarios
Three ported to the desktop target, each pressing
ControlOrMeta+…like the other desktop scenarios. All three pass locally withvp run scenarios --target desktop:scripts/scenarios/thread-find-matches-dotted-capital-i.e2e.ts(a4d0151700)scripts/scenarios/find-reveals-clipped-table-cell.e2e.ts(5bc2d512e4)scripts/scenarios/html-report-in-dot-folder.e2e.ts(6d05c5f496)None were deferred.
Follow-ups
Queued in the follow-up queue (
## From sync chore/upstream-sync-20261120-0233). The batch fix threadBatched fixes: Force stop/session release, PR watch, mobile RTL…(queue 2026-11-20 00:35) is still running, so no new thread was started.All of these are upstream code as written:
git count-objects -vonly to read the alternates.sidebar.togglewithwhen: terminalFocusnever fire.From the second bundle, queued under
## From sync chore/upstream-sync-20261120-0233, second bundle. The same batch thread is still running, so no new thread was started. All of these are upstream code as written, and Codex raised all of them:.reportsis later swapped for a symlink to another hidden folder, the URL serves that folder's previewable files.éneedlefill the per-file cap, so a later standaloneneedlein that file is skipped.Left to upstream (Grok/ACP only), both from 5f8ab374af:
session/loadreply drops the model catalog.Desktop follow-up, not queued: keyboard access (Shift+F10 / ContextMenu key) to a search result's thread actions. Focus stays in the search box.
Review findings
Codex gpt-6.2-astra (high) and a Claude Opus subagent reviewed the same brief independently.
count-objectscost per refresh. Raised by both. Queued.Second bundle (head db661c6, then 58b818b for the watcher), reviewed independently by Codex gpt-6.2-astra (high) and a Claude Opus subagent on the same brief:
/renameconflict resolution, the fixture change and the scenario key presses.Checks
Second bundle:
vp run check:changed 1303c1d45cpasses (typecheck of 41 packages, 27 test files, React Compiler check), and so dovp run i18n:check, the wide-table Find cases inMessagesTimeline.browser.test.tsx, the ProviderSwitch, ThreadStop and ThreadManagementService suites, and the three scenarios.First bundle:
vp run check:changedpasses except three cases inapps/server/src/vcs/GitVcsDriver.test.ts: "checkpoint bulk staging cleans operation-owned packs after interrupt/timeout/success and can retry". They fail the same way on this macOS host with origin/main's VCS sources (ENOENTreading the privatepackdirectory), so they are unrelated to this sync. CI runs them on Linux.Done with Claude Opus 5.5 in Claude Code, reviewed by Codex gpt-6.2-astra and Claude Opus 5.5.
🤖 Generated with Claude Code