Repository navigation
fix: desktop updates resume a short 206, ambiguous citations stay ambiguous, and mobile mentions keep retained models - #453
Merged
Conversation
…iguous, and mobile mentions keep retained models - The patched electron-updater treats a resumed 206 that ends before its declared total as a stall and asks for the rest. - A project root left ambiguous by case still counts as listing the name, so an overlapping root cannot make the citation open one file. - The model picker's readiness rule moves to client-runtime; mobile mentions and prompt links use it, so models kept after a failed check stay offered. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… kept after a failed check Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three follow-ups from upstream sync reviews, one per surface.
What was wrong and the fix
Rangerequest and checked only where the 206 started. A mirror that answeredbytes 4-7/12let it finish the file at 8 bytes. The whole-file digest then failed withERR_CHECKSUM_MISMATCH, and bytes 8-11 were never requested.team/Foo.tsandarchive/FOO.tsunder/repo). It added nothing to the root hit count. With/repo/teamalso registered, the count was 1, the cross-root scan was skipped, andfoo.tsopened/repo/team/Foo.ts.@mentions dropped retained models. After a failed provider check, the server publishesstatus: "error"withmodelsRetained: true. Desktop's model picker kept offering the models, but mobile's mention menu requiredstatus === "ready".@onicode/client-runtime/providerPickerReadiness. Desktop's picker and mobile mentions use it. Prompt links keep preferring a ready, then a warning instance, and fall back to one that kept its models, so aprovider=codexlink no longer drops to the default model while the pickers still offer Codex.Tests
ElectronHttpExecutor.test.ts: a resumed response that ends early is followed by a request for the rest, and the file completes.workspaceBasenameLookup.test.ts: an ambiguous root plus an overlapping root returns no single match.use-composer-command-menu.test.ts: a provider that kept its models after a failed check is offered in mentions.promptLinks.test.ts: a prompt link resolves to an instance that kept its models after a failed check.main.Rejected
Content-Encoding. The concern was that a gzip-encoding mirror would make the decoded byte count a wrongRangeoffset. GitHub and R2 release assets send noContent-Encoding, and undici sendsaccept-encoding: identitywith aRangerequest, so no host Onicode downloads from can trigger it.Council review
Round 1: Codex (gpt-6.2-sol, high) and Claude Opus. Both confirmed the three fixes and that each new case fails on
mainfor the right reason.readysnapshot that is not installed or is signed out no longer passes. No provider reports that combination. Kept, since it matches mobile's rule.Defaultmodel while fx's default backend is signed out and another backend is usable. Desktop's picker already does the same, becauseDefaultcarries no backend. Left, see below.Round 2: both reviewers on the prompt-link change.
errorinstance win over a usablewarningone, and dropped warning instances that resolved before (Claude's account check still pending). Fixed: prompt links keepmain's ready-then-warning order and use a retained-models instance only last.Left
Defaultwith a signed-out default backend is offered by both pickers and mobile mentions. fx should publishDefaultunder its backend, or leave it out while that backend is signed out.ERR_CONTENT_LENGTH_MISMATCHor a reset isn't retried either.errorprovider with no retained models, which desktop hides.Opus 5.5 in Claude Code, through Onicode.
🤖 Generated with Claude Code