Skip to content

chore(upstream-sync): port 58 t3code commits - #457

Merged
trancong12102 merged 60 commits into
mainfrom
chore/upstream-sync-20261120-0416
Nov 19, 2026
Merged

trancong12102 merged 60 commits into
mainfrom
chore/upstream-sync-20261120-0416

Conversation

@trancong12102

@trancong12102 trancong12102 commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

Ports 58 t3code commits (49 taken, 9 skipped): client commands become Effects on the caller's fiber, Codex thread names follow renames, /logout needs providers:manage, agents see who sent a message, SSH through a signed-in ControlMaster, plus many server and client fixes.

Risky commits

  • dbee5a0af0 saves, account switches and registrations report their own outcome (mobile). Relay remoteRegistration, Clerk managedAuth and the crash-report (telemetry) hunks are left out. The notifications screen, which Onicode rewrote, gets the same saveMobilePreferences change by hand.
  • 73caab68e3 commands run as Effects on the caller's fiber (54 files, client-runtime, web, mobile). The outside-app MCP approval code, the relay discovery test and the relay Live Activity hunks are left out. The Onicode-only ThreadVisitWatermark presence test now mocks the command as an Effect.
  • 571c27acab MCP apps resume an idle Codex thread in its own workspace. Codex adapter diverges; hunks applied as is.
  • 5478e44cc9 every repeated --plugin-dir loads its plugin (Claude adapter). Taken as is.
  • 47583f8682 Codex goal turns after a restart are paused. Taken as is.
  • 4c099280f6 dev runner never points a dev server at the live ~/.onicode/userdata. AGENTS.md keeps Onicode's desktop dev lines (no --share, no web dev auth) and gains only the plain-clone sentences.
  • 4fccab84a0 Codex apps and plugins stay off during text generation. Taken as is.
  • d6b5aac30a oni_project_create names the refusing link. Only the link-naming part is taken; see the keep decision below.
  • 767f194fd9 Codex thread name follows Onicode renames. CONFLICT in the capacity-retry test: Onicode's keep-steered-notes case stays, its steer shares request id 4 with the rename and tier cases (never together).
  • c8b214158e Antigravity 1.5 temporary sessions clean up. Taken as is.
  • ae268d9350 a provider CLI that dies at startup names its exit and EPERM. Taken as is.
  • 3b199e77fb thread search indexes displayed file line ranges (contracts). Import CONFLICT in ChatMarkdown.tsx resolved without the unused isElectron. New theme search field is optional, so older mobile builds and servers are unaffected. Scenario ported (see below).
  • 56cd653164 mobile goal pill can be cleared or resumed. CONFLICT in use-thread-composer-state.ts: onSendCommand is wrapped in useStableCallback like sendMessage, and ThreadDetailBody calls it as a destructured local, so reactCompilerCoverage stays green (it failed with whole-props as ported).
  • b5481adcd8 scheduled tasks from Settings start from the default branch (web, mobile, client-runtime export). The conflicts were webhook leftovers; webhook denial, imports and the dedupe-key test are left out.
  • 3cd98dcbae a secret card closes after the steering restart that supersedes it (Orchestrator). Taken as is.
  • b5bef4d939 /logout in chat needs providers:manage (auth). Onicode removed guest links and analytics, so dispatchCommand has no guest-attachment step and the queued-edit test runs without AnalyticsService; the intake test gets back its MessageId import.
  • f8d7f48913 desktop SSH through a signed-in ControlMaster. CONFLICT in tunnel.ts: upstream's operation body with Onicode's Effect.onError scope cleanup (same exits as upstream's onExit + isSuccess).
  • b0b2c4f952 agents can tell another agent's message from the user's (contracts, turn start, handoff history). CONFLICT with Onicode's manual resume prompt, which stays; the sender note wraps only the normal text. Two Onicode-only tests (a steer resuming a stopped queue, a scheduled fresh session's handoff) now expect the note.
  • 6455fc1a74 mobile composer says why Send is disabled after a failed upload. Taken as is.
  • 2c2191789a react-native-svg Android font-variation-settings patch (native, deps). pnpm-lock.yaml regenerated with vp i; only the patch hash changes.
  • babc83baf1 PR viewer renders GitHub :emoji: (web, mobile, 1.9k-line alias table built lazily on first use). Taken as is.
  • 66b8a94f8d delegated task finalize reads less (migration). Migration renumbered to Onicode 106; its index comment names Onicode migration 90 (upstream 84, identical LastExecutedRunIndex). reconcileV2PreviewMigration.test.ts updated.
  • 210996207d mobile PR files follow web's review order (mobile, client-runtime export). Taken as is.
  • 6b6950adfe Android diff word highlights sit on the changed characters (mobile, Kotlin only; bundled after the PR opened). Taken as is; files differed from upstream only by the rebrand. ReviewDiffGeometryTest passes, including the new kerning case. Changes the native fingerprint like 2c2191789a.

Routine commits (taken as is unless noted)

1d3932570c themes keep escaped quotes · f6881ceba0 ACP managed npm off PATH · a2a463a32e gh D-Bus leak · eb62a37150 atomic saves keep modes and fsync (telemetry test left out; every caller writes state/cache files, so two fsyncs per save are fine) · 6d6c4614aa request_secret new card on reused clientRequestId · 1a51984153 tool-call diff relative paths · 56b0777774 GPT evals use configured Codex provider (test-signal README left out; capitalised a sentence start) · 54038e14ec Pi PR linking rules · 178a2f1cd4 oni_thread_launch refuses unreadable HEAD · a8b57b07ea parents revert after subagents complete · ebb3dd0b76 GitHub app sign-in refused refresh signs out · 916fcdc364 project action drafts survive failed imports · c5badf4e40 Git controls scoped to checkout · b68d29b2f7 cleanup removes clean detached worktrees on a branch · e7b61491a3 delivered failed-run handoff not re-sent · 4b697be849 deleted ACP sessions stay out of listings · 9d0d00656f Antigravity cwd stays in workspace · 40c1e861ee / f0f9de46c6 / 98af8803fe sidebar update capsule (no channel logic, better-update unaffected) · 02c5270a11 SSH checks stay pending · f9e45e4363 no-swap hosts OOM-kill instead of throttle · c4419dadd9 Working stays during background waits (Claude/OpenCode) · cdeacd547a turn start reads restart-note history once · 296f9131f7 Cmd+W closes the browser tab

Adopt-or-keep decisions

  • kept Onicode's ProjectService.create default-model handling (d6b5aac30a): it already saves defaultModelSelection through writeProjectSettings (279b2ed), so upstream's refusal would turn a working input into an error.
  • kept Onicode's CLAUDE_REMOVAL_SAFETY_REASONS (554be2c617 skipped): it already matches the reworded check behind a reason-type guard; the same test row exists.
  • kept Onicode's single mcp__onicode__ Pi registration (34a7ab3641 skipped): upstream's public and alias names both translate to it; Onicode dropped the alias in 829d4cf.
  • kept Onicode's collapsed linked-issue rows (b111b6310a skipped): they already collapse per thread, defer hidden summary reads and guard the sidebar badge click.
  • kept Onicode's keep-steered-notes capacity-retry case (767f194fd9).
  • kept Onicode's Effect.onError tunnel cleanup (f8d7f48913), from the Effect 4.1.4 deps pass; equivalent to upstream's.
  • kept Onicode's manual resume prompt (b0b2c4f952).
  • AGENTS.md (4c099280f6): kept Onicode's desktop dev lines; upstream's web/--share lines do not apply.

Skipped

  • 46b14a6808: relay device registration and Live Activity link UI, removed in Onicode.
  • 938feb3246: T3 Connect headless login.
  • 3f5cc38805: T3 Connect device approval.
  • 314a11498e: relay cloudAccountService.
  • c3e82a93fe: T3 Connect cloudflared version.
  • 554be2c617, 34a7ab3641, b111b6310a: see keep decisions.
  • cae24a6f0e: T3 nightly feed check.

E2E scenarios

Ported to the desktop target (none deferred):

  • theme-renders-escaped-quotation-marks.e2e.ts (1d3932570c)
  • project-action-draft-survives-failed-import.e2e.ts (916fcdc364)
  • failed-commit-message-stays-in-its-repository.e2e.ts (c5badf4e40)
  • thread-find-matches-file-line-range.e2e.ts (3b199e77fb), presses ControlOrMeta+f
  • acp-refresh-keeps-deleted-session-removed.e2e.ts (4b697be849)
  • device-host-test-keeps-pending-status.e2e.ts (02c5270a11)

All six pass locally with vp run scenarios --target desktop.

Follow-ups

  • babc83baf1: GitLab also renders :emoji: shortcodes in MR descriptions; the PR viewer turns them on for GitHub only.
  • b0b2c4f952: the sender note is model-facing text; worth an evals/ case for agent-sent and scheduled messages.

Upstream-as-written bugs found in review (all in Claude, Codex, shared core or the GitHub path) are queued and handed to one batched fix thread, Batch fix 0526 (mcp:launch:69dfa78c…), together with the earlier unhanded queue sections. Nothing is patched into this PR:

  • b0b2c4f952: agent text starting with a path or $VAR skips the sender note (Claude).
  • 210996207d: PR file ordering is quadratic per diff page, now also on mobile (Codex).
  • 767f194fd9: a failed Codex rename is retried every turn start, up to 10 s each (Claude).
  • 56cd653164: mobile goal Clear/Resume switches a Plan-mode thread to default mode (Codex).
  • b68d29b2f7: storage cleanup ignores a paused cherry-pick (Codex).
  • 178a2f1cd4: the HEAD probe misreads a localized Git (Codex).
  • babc83baf1: desktop expands :emoji: inside inline HTML <code> (Codex).
  • 4c099280f6: the live-home guard compares path strings, so a symlink passes (Codex).

Bundled increment (6b6950adfe), queued but not handed off while Batch fix 0526 runs: Android word-diff highlights assume left-to-right text (both, as before the commit); check whether iOS places word-diff highlights correctly with kerning and non-ASCII text (Claude).

Left to upstream (other providers or forges): none this time.

Note: 2c2191789a changes the mobile native fingerprint (pnpm patch), so over-the-air updates will not reach installed builds until new native builds ship.

Review findings

Codex gpt-6.2-astra and a Claude Opus 5.5 subagent reviewed head b129862 with the same brief.

  • Neither found a bug in the ports' conflict resolutions, stripped hunks or the renumbered migration, and neither disputed a keep decision.
  • AGENTS.md plain-clone sentence ignored ONICODE_HOME (Codex): fixed in 3b74124.
  • Scenario settings leftovers (Codex): first queued as upstream-as-written, then CI proved it: in Desktop scenarios 2 the ACP scenario left an enabled provider behind and disabled-provider-leaves-composer-asking never saw "Enable a provider". Fixed in 859a22e (both scenarios restore settings in finally); reproduced failing and passing locally.
  • GitLab :emoji: (both): follow-up, queued.
  • Upstream-as-written bugs (listed under Follow-ups, with who raised each): queued to the batch thread.

The bundled 6b6950adfe was reviewed on 10e0cf4 by Codex gpt-6.2-sol and a Claude Opus 5.5 subagent: both found the port identical to upstream with no fork harm. Both noted an extra text-measure pass per redraw on rows with word diffs: dismissed, since only drawn rows pay it, the pass stops at the last changed range, and the old fixed-width math put highlights on the wrong characters. Claude's out-of-range-end note is dismissed: ranges come from the server's own diff of the same content. RTL and the iOS check are queued (above).

Checks

vp run check:changed passes on b129862: format, lint, knip, typecheck of 41 packages, 132 test files (4066 tests), React Compiler check on 80 files. vp run i18n:check passes. check:changed 3b74124816 passes on 10e0cf4. Per-commit checks for the risky ones are in the commit list above; the migration tests and reconcileV2PreviewMigration.test.ts pass.

Done with Claude Opus 5.5 in Claude Code, reviewed by Codex gpt-6.2-astra (gpt-6.2-sol for the bundled commit) and Claude Opus 5.5.

🤖 Generated with Claude Code

StiensWout and others added 30 commits November 20, 2026 04:31
Ported from pingdotgg/t3code@1d3932570c.

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ir own outcome (#38911)

Ported from pingdotgg/t3code@dbee5a0af0. Onicode has no relay remoteRegistration, Clerk managedAuth or crash-report setting, so those hunks are left out. The notifications screen, which Onicode rewrote, gets the same saveMobilePreferences change by hand.

Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…upting a caller stops them (#38912)

Ported from pingdotgg/t3code@73caab68e3. The outside-app MCP approval code, the relay discovery test and the relay Live Activity notifications hunks are left out (removed in Onicode). The Onicode-only ThreadVisitWatermark presence test now mocks the command as an Effect too.

Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Ported from pingdotgg/t3code@f6881ceba0.

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…e (#38468)

Ported from pingdotgg/t3code@571c27acab.

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Ported from pingdotgg/t3code@a2a463a32e.

Co-authored-by: HelixNebula <249811984+helixnebulatech@users.noreply.github.com>
Ported from pingdotgg/t3code@eb62a37150. The telemetry Identify test is left out (telemetry is removed). Every Onicode caller writes state or cache files, not per-event paths, so the two fsyncs per save are fine.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ugin (#38634)

Ported from pingdotgg/t3code@5478e44cc9.

Co-authored-by: asssslay <avramova.ruslana.a.r.r@gmail.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…a clientRequestId (#38167)

Ported from pingdotgg/t3code@6d6c4614aa.

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…/userdata (#38807)

Ported from pingdotgg/t3code@4c099280f6. AGENTS.md keeps Onicode's desktop dev lines (no --share or web dev auth) and gains only the plain-clone sentences.

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…#39086)

Ported from pingdotgg/t3code@4fccab84a0.

Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com>
…e (#32697)

Ported from pingdotgg/t3code@1a51984153.

Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
…E (#38573)

Ported from pingdotgg/t3code@56b0777774. Onicode has no test-signal eval, so its README change is left out.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Ported from pingdotgg/t3code@54038e14ec.

Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Ported from pingdotgg/t3code@a8b57b07ea.

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…jects a model default it would drop (#30471)

Ported from pingdotgg/t3code@d6b5aac30a. Only the link-naming refusal is taken. Kept Onicode's ProjectService.create default-model handling: it already saves defaultModelSelection through writeProjectSettings (279b2ed), so upstream's refusal of that input, and its test, are left out.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…312)

Ported from pingdotgg/t3code@916fcdc364.

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Ported from pingdotgg/t3code@767f194fd9. The capacity-retry test keeps Onicode's keep-steered-notes case; its steer uses request id 4 like the rename and tier cases, which never occur together.

Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… clean up their files (#39275)

Ported from pingdotgg/t3code@c8b214158e.

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Ported from pingdotgg/t3code@c5badf4e40.

Co-authored-by: Julius Marminge <julius0216@outlook.com>
juliusmarminge and others added 26 commits November 20, 2026 04:51
Ported from pingdotgg/t3code@56cd653164. onSendCommand is wrapped in useStableCallback like sendMessage and called as a destructured local in ThreadDetailBody, so the composer and thread body keep their compiled caches (reactCompilerCoverage).

Co-authored-by: ravdeep kainth <kainth.ravdeep@gmail.com>
Co-authored-by: voida6 <voida6@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…'s default branch (#32841)

Ported from pingdotgg/t3code@b5481adcd8. The webhook schedule parts (policy denial, webhook imports, dedupe-key test) are left out; Onicode removed webhooks.

Co-authored-by: Ajraba04 <143622128+Ajraba04@users.noreply.github.com>
Co-authored-by: maria-rcks <maria@kuuro.net>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Ported from pingdotgg/t3code@4b697be849.

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…achmentsDir from additionalDirectories (#37997)

Ported from pingdotgg/t3code@9d0d00656f.

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ersedes it (#34634)

Ported from pingdotgg/t3code@3cd98dcbae.

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Ported from pingdotgg/t3code@98af8803fe.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Ported from pingdotgg/t3code@02c5270a11.

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Ported from pingdotgg/t3code@b5bef4d939. Onicode removed guest links and analytics, so dispatchCommand gets no guest-attachment step and the queued-edit test runs without AnalyticsService.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…gned-in ControlMaster (#30616)

Ported from pingdotgg/t3code@f8d7f48913. Kept Onicode's Effect.onError cleanup of the tunnel scope from the Effect 4.1.4 deps pass (23d36e1); it closes the scope on the same exits as upstream's onExit with an isSuccess check.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…background wait between turns (#38638)

Ported from pingdotgg/t3code@c4419dadd9.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Ported from pingdotgg/t3code@296f9131f7.

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…(#39306)

Ported from pingdotgg/t3code@b0b2c4f952. The sender note wraps the provider text below Onicode's manual resume prompt, which stays as is. Two Onicode-only tests (a steer resuming a stopped queue, a scheduled fresh session's handoff) now expect the note.

Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…pload fails (#38395)

Ported from pingdotgg/t3code@6455fc1a74.

Co-authored-by: Julius Marminge <julius0216@outlook.com>
…Android (#39334)

Ported from pingdotgg/t3code@2c2191789a. pnpm-lock.yaml is regenerated with vp i against Onicode's lockfile, so only the react-native-svg patch hash changes.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… whole turn history (#39325)

Ported from pingdotgg/t3code@66b8a94f8d. The migration takes Onicode's next free number, 106, and its index comment names Onicode migration 90 (upstream 84, the same LastExecutedRunIndex).
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Follow-up to the port of pingdotgg/t3code@4c099280f6: the plain-clone sentence named ~/.onicode/dev even when ONICODE_HOME is set, which the dev runner uses first.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…rs (#33568)

Ported from pingdotgg/t3code@6b6950adfe.

Co-authored-by: Julius Marminge <julius0216@outlook.com>
@trancong12102 trancong12102 changed the title chore(upstream-sync): port 57 t3code commits chore(upstream-sync): port 58 t3code commits Nov 19, 2026
Follow-up to 28b0f2e (t3code@4b697be849) and 8b61d70 (t3code@02c5270a11). Scenarios share one server, so the ACP scenario left an enabled provider behind and disabled-provider-leaves-composer-asking, which runs after it in Desktop scenarios 2, never saw "Enable a provider". Both now put their settings back in finally.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@trancong12102
trancong12102 merged commit 6cbf776 into main Nov 19, 2026
23 checks passed
@trancong12102
trancong12102 deleted the chore/upstream-sync-20261120-0416 branch November 19, 2026 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.