Repository navigation
chore(upstream-sync): port 58 t3code commits - #457
Merged
Merged
Conversation
Ported from pingdotgg/t3code@1d3932570c. Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ir own outcome (#38911) Ported from pingdotgg/t3code@dbee5a0af0. Onicode has no relay remoteRegistration, Clerk managedAuth or crash-report setting, so those hunks are left out. The notifications screen, which Onicode rewrote, gets the same saveMobilePreferences change by hand. Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…upting a caller stops them (#38912) Ported from pingdotgg/t3code@73caab68e3. The outside-app MCP approval code, the relay discovery test and the relay Live Activity notifications hunks are left out (removed in Onicode). The Onicode-only ThreadVisitWatermark presence test now mocks the command as an Effect too. Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Ported from pingdotgg/t3code@f6881ceba0. Co-authored-by: Julius Marminge <julius0216@outlook.com>
…e (#38468) Ported from pingdotgg/t3code@571c27acab. Co-authored-by: Julius Marminge <julius0216@outlook.com>
Ported from pingdotgg/t3code@a2a463a32e. Co-authored-by: HelixNebula <249811984+helixnebulatech@users.noreply.github.com>
Ported from pingdotgg/t3code@eb62a37150. The telemetry Identify test is left out (telemetry is removed). Every Onicode caller writes state or cache files, not per-event paths, so the two fsyncs per save are fine. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…ugin (#38634) Ported from pingdotgg/t3code@5478e44cc9. Co-authored-by: asssslay <avramova.ruslana.a.r.r@gmail.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…a clientRequestId (#38167) Ported from pingdotgg/t3code@6d6c4614aa. Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ad of running unseen (#25935) Ported from pingdotgg/t3code@47583f8682.
…/userdata (#38807) Ported from pingdotgg/t3code@4c099280f6. AGENTS.md keeps Onicode's desktop dev lines (no --share or web dev auth) and gains only the plain-clone sentences. Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…#39086) Ported from pingdotgg/t3code@4fccab84a0. Co-authored-by: Simone <185146821+Lucenx9@users.noreply.github.com>
…e (#32697) Ported from pingdotgg/t3code@1a51984153. Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…E (#38573) Ported from pingdotgg/t3code@56b0777774. Onicode has no test-signal eval, so its README change is left out. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Ported from pingdotgg/t3code@54038e14ec. Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…en Git cannot read HEAD (#38459) Ported from pingdotgg/t3code@178a2f1cd4.
Ported from pingdotgg/t3code@a8b57b07ea. Co-authored-by: Julius Marminge <julius0216@outlook.com>
…jects a model default it would drop (#30471) Ported from pingdotgg/t3code@d6b5aac30a. Only the link-naming refusal is taken. Kept Onicode's ProjectService.create default-model handling: it already saves defaultModelSelection through writeProjectSettings (279b2ed), so upstream's refusal of that input, and its test, are left out. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… refresh for the client's credentials (#39048) Ported from pingdotgg/t3code@ebb3dd0b76.
…312) Ported from pingdotgg/t3code@916fcdc364. Co-authored-by: Julius Marminge <julius0216@outlook.com>
Ported from pingdotgg/t3code@767f194fd9. The capacity-retry test keeps Onicode's keep-steered-notes case; its steer uses request id 4 like the rename and tier cases, which never occur together. Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… clean up their files (#39275) Ported from pingdotgg/t3code@c8b214158e. Co-authored-by: Julius Marminge <julius0216@outlook.com>
…PERM (#39299) Ported from pingdotgg/t3code@ae268d9350.
Ported from pingdotgg/t3code@c5badf4e40. Co-authored-by: Julius Marminge <julius0216@outlook.com>
Ported from pingdotgg/t3code@56cd653164. onSendCommand is wrapped in useStableCallback like sendMessage and called as a destructured local in ThreadDetailBody, so the composer and thread body keep their compiled caches (reactCompilerCoverage). Co-authored-by: ravdeep kainth <kainth.ravdeep@gmail.com> Co-authored-by: voida6 <voida6@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…'s default branch (#32841) Ported from pingdotgg/t3code@b5481adcd8. The webhook schedule parts (policy denial, webhook imports, dedupe-key test) are left out; Onicode removed webhooks. Co-authored-by: Ajraba04 <143622128+Ajraba04@users.noreply.github.com> Co-authored-by: maria-rcks <maria@kuuro.net> Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Ported from pingdotgg/t3code@4b697be849. Co-authored-by: Julius Marminge <julius0216@outlook.com>
…achmentsDir from additionalDirectories (#37997) Ported from pingdotgg/t3code@9d0d00656f. Co-authored-by: Julius Marminge <julius0216@outlook.com>
…ersedes it (#34634) Ported from pingdotgg/t3code@3cd98dcbae. Co-authored-by: Julius Marminge <julius0216@outlook.com>
Ported from pingdotgg/t3code@98af8803fe. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Ported from pingdotgg/t3code@02c5270a11. Co-authored-by: Julius Marminge <julius0216@outlook.com>
Ported from pingdotgg/t3code@b5bef4d939. Onicode removed guest links and analytics, so dispatchCommand gets no guest-attachment step and the queued-edit test runs without AnalyticsService. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…gned-in ControlMaster (#30616) Ported from pingdotgg/t3code@f8d7f48913. Kept Onicode's Effect.onError cleanup of the tunnel scope from the Effect 4.1.4 deps pass (23d36e1); it closes the scope on the same exits as upstream's onExit with an isSuccess check. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…hrottled for hours (#39287) Ported from pingdotgg/t3code@f9e45e4363.
…background wait between turns (#38638) Ported from pingdotgg/t3code@c4419dadd9. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Julius Marminge <julius0216@outlook.com>
…nce (#39241) Ported from pingdotgg/t3code@cdeacd547a.
Ported from pingdotgg/t3code@296f9131f7. Co-authored-by: Julius Marminge <julius0216@outlook.com>
…(#39306) Ported from pingdotgg/t3code@b0b2c4f952. The sender note wraps the provider text below Onicode's manual resume prompt, which stays as is. Two Onicode-only tests (a steer resuming a stopped queue, a scheduled fresh session's handoff) now expect the note. Co-authored-by: Julius Marminge <julius0216@outlook.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…pload fails (#38395) Ported from pingdotgg/t3code@6455fc1a74. Co-authored-by: Julius Marminge <julius0216@outlook.com>
…Android (#39334) Ported from pingdotgg/t3code@2c2191789a. pnpm-lock.yaml is regenerated with vp i against Onicode's lockfile, so only the react-native-svg patch hash changes. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
… whole turn history (#39325) Ported from pingdotgg/t3code@66b8a94f8d. The migration takes Onicode's next free number, 106, and its index comment names Onicode migration 90 (upstream 84, the same LastExecutedRunIndex). Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Follow-up to the port of pingdotgg/t3code@4c099280f6: the plain-clone sentence named ~/.onicode/dev even when ONICODE_HOME is set, which the dev runner uses first. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…rs (#33568) Ported from pingdotgg/t3code@6b6950adfe. Co-authored-by: Julius Marminge <julius0216@outlook.com>
Follow-up to 28b0f2e (t3code@4b697be849) and 8b61d70 (t3code@02c5270a11). Scenarios share one server, so the ACP scenario left an enabled provider behind and disabled-provider-leaves-composer-asking, which runs after it in Desktop scenarios 2, never saw "Enable a provider". Both now put their settings back in finally. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports 58 t3code commits (49 taken, 9 skipped): client commands become Effects on the caller's fiber, Codex thread names follow renames, /logout needs providers:manage, agents see who sent a message, SSH through a signed-in ControlMaster, plus many server and client fixes.
Risky commits
remoteRegistration, ClerkmanagedAuthand the crash-report (telemetry) hunks are left out. The notifications screen, which Onicode rewrote, gets the samesaveMobilePreferenceschange by hand.ThreadVisitWatermarkpresence test now mocks the command as an Effect.--plugin-dirloads its plugin (Claude adapter). Taken as is.~/.onicode/userdata. AGENTS.md keeps Onicode's desktop dev lines (no--share, no web dev auth) and gains only the plain-clone sentences.oni_project_createnames the refusing link. Only the link-naming part is taken; see the keep decision below.keep-steered-notescase stays, its steer shares request id 4 with the rename and tier cases (never together).ChatMarkdown.tsxresolved without the unusedisElectron. Newthemesearch field is optional, so older mobile builds and servers are unaffected. Scenario ported (see below).use-thread-composer-state.ts:onSendCommandis wrapped inuseStableCallbacklikesendMessage, andThreadDetailBodycalls it as a destructured local, soreactCompilerCoveragestays green (it failed withwhole-propsas ported)./logoutin chat needsproviders:manage(auth). Onicode removed guest links and analytics, sodispatchCommandhas no guest-attachment step and the queued-edit test runs withoutAnalyticsService; the intake test gets back itsMessageIdimport.tunnel.ts: upstream's operation body with Onicode'sEffect.onErrorscope cleanup (same exits as upstream'sonExit+isSuccess).pnpm-lock.yamlregenerated withvp i; only the patch hash changes.:emoji:(web, mobile, 1.9k-line alias table built lazily on first use). Taken as is.LastExecutedRunIndex).reconcileV2PreviewMigration.test.tsupdated.ReviewDiffGeometryTestpasses, including the new kerning case. Changes the native fingerprint like 2c2191789a.Routine commits (taken as is unless noted)
1d3932570c themes keep escaped quotes · f6881ceba0 ACP managed npm off PATH · a2a463a32e gh D-Bus leak · eb62a37150 atomic saves keep modes and fsync (telemetry test left out; every caller writes state/cache files, so two fsyncs per save are fine) · 6d6c4614aa request_secret new card on reused clientRequestId · 1a51984153 tool-call diff relative paths · 56b0777774 GPT evals use configured Codex provider (test-signal README left out; capitalised a sentence start) · 54038e14ec Pi PR linking rules · 178a2f1cd4 oni_thread_launch refuses unreadable HEAD · a8b57b07ea parents revert after subagents complete · ebb3dd0b76 GitHub app sign-in refused refresh signs out · 916fcdc364 project action drafts survive failed imports · c5badf4e40 Git controls scoped to checkout · b68d29b2f7 cleanup removes clean detached worktrees on a branch · e7b61491a3 delivered failed-run handoff not re-sent · 4b697be849 deleted ACP sessions stay out of listings · 9d0d00656f Antigravity cwd stays in workspace · 40c1e861ee / f0f9de46c6 / 98af8803fe sidebar update capsule (no channel logic, better-update unaffected) · 02c5270a11 SSH checks stay pending · f9e45e4363 no-swap hosts OOM-kill instead of throttle · c4419dadd9 Working stays during background waits (Claude/OpenCode) · cdeacd547a turn start reads restart-note history once · 296f9131f7 Cmd+W closes the browser tab
Adopt-or-keep decisions
ProjectService.createdefault-model handling (d6b5aac30a): it already savesdefaultModelSelectionthroughwriteProjectSettings(279b2ed), so upstream's refusal would turn a working input into an error.CLAUDE_REMOVAL_SAFETY_REASONS(554be2c617 skipped): it already matches the reworded check behind a reason-type guard; the same test row exists.mcp__onicode__Pi registration (34a7ab3641 skipped): upstream's public and alias names both translate to it; Onicode dropped the alias in 829d4cf.keep-steered-notescapacity-retry case (767f194fd9).Effect.onErrortunnel cleanup (f8d7f48913), from the Effect 4.1.4 deps pass; equivalent to upstream's.--sharelines do not apply.Skipped
E2E scenarios
Ported to the desktop target (none deferred):
theme-renders-escaped-quotation-marks.e2e.ts(1d3932570c)project-action-draft-survives-failed-import.e2e.ts(916fcdc364)failed-commit-message-stays-in-its-repository.e2e.ts(c5badf4e40)thread-find-matches-file-line-range.e2e.ts(3b199e77fb), pressesControlOrMeta+facp-refresh-keeps-deleted-session-removed.e2e.ts(4b697be849)device-host-test-keeps-pending-status.e2e.ts(02c5270a11)All six pass locally with
vp run scenarios --target desktop.Follow-ups
:emoji:shortcodes in MR descriptions; the PR viewer turns them on for GitHub only.evals/case for agent-sent and scheduled messages.Upstream-as-written bugs found in review (all in Claude, Codex, shared core or the GitHub path) are queued and handed to one batched fix thread, Batch fix 0526 (
mcp:launch:69dfa78c…), together with the earlier unhanded queue sections. Nothing is patched into this PR:$VARskips the sender note (Claude).:emoji:inside inline HTML<code>(Codex).Bundled increment (6b6950adfe), queued but not handed off while Batch fix 0526 runs: Android word-diff highlights assume left-to-right text (both, as before the commit); check whether iOS places word-diff highlights correctly with kerning and non-ASCII text (Claude).
Left to upstream (other providers or forges): none this time.
Note: 2c2191789a changes the mobile native fingerprint (pnpm patch), so over-the-air updates will not reach installed builds until new native builds ship.
Review findings
Codex gpt-6.2-astra and a Claude Opus 5.5 subagent reviewed head b129862 with the same brief.
ONICODE_HOME(Codex): fixed in 3b74124.disabled-provider-leaves-composer-askingnever saw "Enable a provider". Fixed in 859a22e (both scenarios restore settings infinally); reproduced failing and passing locally.:emoji:(both): follow-up, queued.The bundled 6b6950adfe was reviewed on 10e0cf4 by Codex gpt-6.2-sol and a Claude Opus 5.5 subagent: both found the port identical to upstream with no fork harm. Both noted an extra text-measure pass per redraw on rows with word diffs: dismissed, since only drawn rows pay it, the pass stops at the last changed range, and the old fixed-width math put highlights on the wrong characters. Claude's out-of-range-end note is dismissed: ranges come from the server's own diff of the same content. RTL and the iOS check are queued (above).
Checks
vp run check:changedpasses on b129862: format, lint, knip, typecheck of 41 packages, 132 test files (4066 tests), React Compiler check on 80 files.vp run i18n:checkpasses.check:changed 3b74124816passes on 10e0cf4. Per-commit checks for the risky ones are in the commit list above; the migration tests andreconcileV2PreviewMigration.test.tspass.Done with Claude Opus 5.5 in Claude Code, reviewed by Codex gpt-6.2-astra (gpt-6.2-sol for the bundled commit) and Claude Opus 5.5.
🤖 Generated with Claude Code