Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update file_system dependency #7

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

nshafer
Copy link
Contributor

@nshafer nshafer commented Jun 4, 2024

When trying to add this module to an existing phoenix application, there is an unsolvable dependency issue:

$ mix deps.get
Resolving Hex dependencies...
Resolution completed in 0.215s
Because "the lock" specifies file_system 1.0.0 and every version of phoenix_copy depends on file_system ~> 0.2, the lock is incompatible with phoenix_copy.
And because your app depends on the lock, no version of phoenix_copy is allowed.
So, because your app depends on phoenix_copy ~> 0.1.3, version solving failed.
** (Mix) Hex dependency resolution failed

The reason that "file_system" is locked to 1.0.0 is because "phoenix_live_reload" has a requirement of {:file_system, "~> 0.2.10 or ~> 1.0"} so 1.0.0 which was published Nov 09, 2023 is being installed.

This PR simply updates the dep line from {:file_system, "~> 0.2"} to {:file_system, "~> 0.2 or ~> 1.0"} so that it will work when added to old or new projects. The changes in "file_system" seem to be pretty minor, and the 1.0.0 was just since it has been stable for years and Jose Valim asked for it.

I unlocked the dep so that tests would run, and also updated ex_doc's locked version so that the generated documentation is updated to the latest styles. I left junit_formatter alone since that's related to your CI.

Thanks for the lib!

@aj-foster
Copy link
Owner

Awesome, thank you! ❤️

@aj-foster aj-foster merged commit 37036ef into aj-foster:main Jun 5, 2024
2 checks passed
@aj-foster
Copy link
Owner

This change has been released in version 0.1.4.

@nshafer
Copy link
Contributor Author

nshafer commented Jun 5, 2024

Thanks for quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants