Skip to content

Remove iOS helpers the app never calls, and the tests that only pinned them - #107

Merged
ajbarryiii merged 2 commits into
mainfrom
cleanup/ios-dead-helpers
Nov 3, 2026
Merged

ajbarryiii merged 2 commits into
mainfrom
cleanup/ios-dead-helpers

Conversation

@ajbarryiii

@ajbarryiii ajbarryiii commented Nov 2, 2026 •

Copy link
Copy Markdown
Owner

Seven iOS helpers had no callers in the app. Three were never referenced at all, and four were called only by tests, so those tests pinned code that never ships. One of them, NeverCorrectOffer.barShows, also described a rule the bar doesn't follow: the bar hides the Never correct offer under a notice too, which BarMiddleContent.resolve decides and barShows had no notion of.

This removes them and the tests that existed only to pin them:

  • NeverCorrectOffer.barShows and its test dictationUIWinsTheBar. The real gate is already pinned by BarContentTests.dictationIsNeverHiddenByTheStripOrTheOffer; the iOS/ARCHITECTURE.md paragraph that named barShows now names BarMiddleContent, notices included.
  • WordLexicon's edgeRange and TrackpadSession.isEnded, which nothing referenced.
  • SharedDictationStore.deleteResult, TapPrior.recentSurprise and SessionActivityState.countdownLead/countdownTail, wrappers and constants that only tests used. The keyboard's menu hard-codes the countdown words, so those constants' doc comment was wrong too.

Contract changes: the removed APIs' tests go with them (dictationUIWinsTheBar, and the single assertion that pinned deleteResult turning .failed into false). Where a test also guarded behaviour the app relies on, it now goes through the production API instead of being dropped. The store tests claim through removeResult, the keyboard's claim path, including the two-process "first wins, the other result survives" case (renamed removeResultReportsWhoRemovedIt). The cold-prior surprise check calls prediction(context:), which the keyboard calls. The countdown test keeps all its KeyboardMessages, timer-symbol and VoiceOver assertions, with the words as literals.

Proof: make -C iOS check passed on the Mac at e4b41fe (type-checks of all three targets, 1081 host tests, plist lint), and CI's Verify, Verify iOS and Verify Linux passed on the same head. git diff --check is clean.

No AGENTS.md high-risk area is touched: there is no behaviour change, and nothing in storage, permissions, clipboard handling or provider requests changes. No manual test is needed.

Commit 525ed9c, added during reconciliation, changes only comments, on lines #111 had to leave alone. KeyboardEditor now cites the current "Typing model" section, and the review-history notes beside the countdown are gone, with their reasons kept.

The reconciliation commit was reviewed by Sol: 1 round, no findings.

Reconciled with #105–#112. Every pair, and the full set, merge onto main without conflicts, so they can merge in any order. All eight merged together pass make check and git diff --check on the Mac. The seven other than #112 also pass make -C iOS check together; #112 changes no file the iOS build compiles.

Created with Claude Opus 5.5 in T3 Code.

Sol Loop: 1 rounds, 0 fixes (0 high, 0 medium, 0 low, 0 rejected)

@github-actions github-actions Bot added the size/s label Nov 2, 2026
@ajbarryiii
ajbarryiii marked this pull request as ready for review November 3, 2026 01:21
@ajbarryiii
ajbarryiii merged commit b8a3dbf into main Nov 3, 2026
4 checks passed
@ajbarryiii
ajbarryiii deleted the cleanup/ios-dead-helpers branch November 3, 2026 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant