Repository navigation
Remove iOS helpers the app never calls, and the tests that only pinned them - #107
Merged
Merged
Conversation
…y pinned on the production APIs
…t beside the countdown
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seven iOS helpers had no callers in the app. Three were never referenced at all, and four were called only by tests, so those tests pinned code that never ships. One of them,
NeverCorrectOffer.barShows, also described a rule the bar doesn't follow: the bar hides the Never correct offer under a notice too, whichBarMiddleContent.resolvedecides andbarShowshad no notion of.This removes them and the tests that existed only to pin them:
NeverCorrectOffer.barShowsand its testdictationUIWinsTheBar. The real gate is already pinned byBarContentTests.dictationIsNeverHiddenByTheStripOrTheOffer; the iOS/ARCHITECTURE.md paragraph that namedbarShowsnow namesBarMiddleContent, notices included.WordLexicon'sedgeRangeandTrackpadSession.isEnded, which nothing referenced.SharedDictationStore.deleteResult,TapPrior.recentSurpriseandSessionActivityState.countdownLead/countdownTail, wrappers and constants that only tests used. The keyboard's menu hard-codes the countdown words, so those constants' doc comment was wrong too.Contract changes: the removed APIs' tests go with them (
dictationUIWinsTheBar, and the single assertion that pinneddeleteResultturning.failedintofalse). Where a test also guarded behaviour the app relies on, it now goes through the production API instead of being dropped. The store tests claim throughremoveResult, the keyboard's claim path, including the two-process "first wins, the other result survives" case (renamedremoveResultReportsWhoRemovedIt). The cold-prior surprise check callsprediction(context:), which the keyboard calls. The countdown test keeps all its KeyboardMessages, timer-symbol and VoiceOver assertions, with the words as literals.Proof:
make -C iOS checkpassed on the Mac at e4b41fe (type-checks of all three targets, 1081 host tests, plist lint), and CI's Verify, Verify iOS and Verify Linux passed on the same head.git diff --checkis clean.No AGENTS.md high-risk area is touched: there is no behaviour change, and nothing in storage, permissions, clipboard handling or provider requests changes. No manual test is needed.
Commit 525ed9c, added during reconciliation, changes only comments, on lines #111 had to leave alone.
KeyboardEditornow cites the current "Typing model" section, and the review-history notes beside the countdown are gone, with their reasons kept.The reconciliation commit was reviewed by Sol: 1 round, no findings.
Reconciled with #105–#112. Every pair, and the full set, merge onto main without conflicts, so they can merge in any order. All eight merged together pass
make checkandgit diff --checkon the Mac. The seven other than #112 also passmake -C iOS checktogether; #112 changes no file the iOS build compiles.Created with Claude Opus 5.5 in T3 Code.
Sol Loop: 1 rounds, 0 fixes (0 high, 0 medium, 0 low, 0 rejected)