Skip to content

Notify supervisord on config directory change. - #125

Open
skrivy wants to merge 1 commit into
ajcurated:masterfrom
skrivy:master
Open

Notify supervisord on config directory change.#125
skrivy wants to merge 1 commit into
ajcurated:masterfrom
skrivy:master

Conversation

@skrivy

@skrivy skrivy commented Nov 23, 2018

Copy link
Copy Markdown

Problematic situation:

class { 'supervisord':
    ...
    config_include       => '/etc/supervisor/conf.d',
    config_include_purge => true,
    ...
}

If we remove any supervisord::program block with this configuration, it's .conf file gets deleted, but supervisord process is not reloaded and removed program remains running.

This patch reconfigures supervisord on the conf directory content change.

@quanghiem

Copy link
Copy Markdown
Contributor

By notifying supervisord::service, puppet will restart the supervisord service on any config change. This should notify supervisord::reload instead so that puppet issues a supervisorctl reread and update instead to avoid any downtime.

@skrivy

skrivy commented Dec 5, 2018

Copy link
Copy Markdown
Author

@quanghiem Feel free to update the PR.

@quanghiem

Copy link
Copy Markdown
Contributor

@skrivy I don't think people can add commits to your PR.

@ajcurated

Copy link
Copy Markdown
Owner

Sorry for the slow reply guys

If @skrivy wants to close this and @quanghiem you want to propose a new PR based on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants