ENH: Check units in xarray and iris interfaces. #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QianyeSu
approved these changes
Aug 17, 2025
QianyeSu
approved these changes
Aug 17, 2025
QianyeSu
approved these changes
Aug 17, 2025
QianyeSu
approved these changes
Aug 17, 2025
rcomer
reviewed
Sep 30, 2025
instead of rolling my own. Co-authored-by: Ruth Comer <[email protected]>
ajdawson
reviewed
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A follow-up to my comment on #74.
The metadata of the output assumes the input winds are in meters per second and the earth's radius is in meters. This PR either checks (XArray) or ensures (iris) those units, and additionally adds units to the results of
VectorWind.gradientwhere the input had units.