-
Couldn't load subscription status.
- Fork 12
Improving header navigation link styles #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SV9045
wants to merge
6
commits into
ajitsinghkaler:main
Choose a base branch
from
SV9045:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b8b5f82
Improving header navigation link styles
SV9045 ca1a4c5
Merge branch 'main' into main
SV9045 00b289a
Implementing 404 (not found page) in app.module
SV9045 65e7606
Merge branch 'main' of https://github.com/SV9045/devto-clone
SV9045 f9f1da0
merging app-routing
SV9045 c03ed1c
removing pathMatch
SV9045 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export const TABS = ['feed', 'week', 'month', 'year', 'infinity', 'latest']; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| <div class="not-found"> | ||
| <h1>The Page you are looking for was not found</h1> | ||
| <a class="go-home" routerLink="/"> | ||
| Return to Home Page | ||
| </a> | ||
| </div> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| .not-found { | ||
| min-height: 100vh; | ||
| display: flex; | ||
| flex-direction: column; | ||
| justify-content: center; | ||
| align-items: center; | ||
| } | ||
|
|
||
| .btn-primary { | ||
| background-color: aqua; | ||
| } | ||
|
|
||
| .go-home { | ||
| font-size: 1.5rem; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import { ComponentFixture, TestBed } from '@angular/core/testing'; | ||
|
|
||
| import { NotFoundComponent } from './not-found.component'; | ||
|
|
||
| describe('NotFoundComponent', () => { | ||
| let component: NotFoundComponent; | ||
| let fixture: ComponentFixture<NotFoundComponent>; | ||
|
|
||
| beforeEach(async () => { | ||
| await TestBed.configureTestingModule({ | ||
| declarations: [ NotFoundComponent ] | ||
| }) | ||
| .compileComponents(); | ||
| }); | ||
|
|
||
| beforeEach(() => { | ||
| fixture = TestBed.createComponent(NotFoundComponent); | ||
| component = fixture.componentInstance; | ||
| fixture.detectChanges(); | ||
| }); | ||
|
|
||
| it('should create', () => { | ||
| expect(component).toBeTruthy(); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| import { Component } from '@angular/core'; | ||
|
|
||
| @Component({ | ||
| selector: 'app-not-found', | ||
| templateUrl: './not-found.component.html', | ||
| styleUrls: ['./not-found.component.scss'], | ||
| }) | ||
| export class NotFoundComponent { | ||
| constructor() {} | ||
| } |
34 changes: 16 additions & 18 deletions
34
src/app/pages/home/articles/article-header/article-header.component.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,18 @@ | ||
| <header class="flex justify-between"> | ||
| <h1 class="subtitle">Posts</h1> | ||
|
|
||
| <nav class="flex" aria-label="View posts by"> | ||
| <ul class="tabs-list flex"> | ||
| <li *ngFor="let tab of tabs"> | ||
| <a [class.active]="tab === selectedTab" class="tab-item pointer">{{tab|titlecase}}</a> | ||
| </li> | ||
| </ul> | ||
| <header class="header flex justify-between align-center"> | ||
| <div class="title-post"> | ||
| <h1 class="subtitle">Posts</h1> | ||
| </div> | ||
| <div class="navbar"> | ||
| <nav class="nav-bar" aria-label="View posts by" role="navigation"> | ||
| <ul class="tabs-list flex" role="list"> | ||
| <li class="tab-list-item" *ngFor="let tab of tabs" role="listitem" [class.active-tab]="tab === selectedTab"> | ||
| <a class="tab-item pointer" role="link"> | ||
| {{ tab | titlecase }} | ||
| </a> | ||
| </li> | ||
| <span class="focus-border"></span> | ||
| </ul> | ||
| </nav> | ||
|
|
||
| <!-- <select class="crayons-select s:hidden ml-2 s:ml-auto w-auto" id="feed-filter-select" aria-label="feed-filter-select"> | ||
| <option value="/" selected="">Feed</option> | ||
| <option value="/top/week">Week</option> | ||
| <option value="/top/month">Month</option> | ||
| <option value="/top/year">Year</option> | ||
| <option value="/top/infinity">Infinity</option> | ||
| <option value="/latest">Latest</option> | ||
| </select> --> | ||
| </header> | ||
| </div> | ||
| </header> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
min-height: calc(100vh - var(--header-height));
this makes it equal to the height of the screen